Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Amit Kucheria
On Thu, Mar 21, 2013 at 4:08 PM, Vinod Koul wrote: > On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote: >> On 21 March 2013 15:16, Vinod Koul wrote: >> > On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: >> >> In of_dma_controller_register() routine we are calling

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Vinod Koul
On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote: > On 21 March 2013 15:16, Vinod Koul wrote: > > On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: > >> In of_dma_controller_register() routine we are calling of_get_property() > >> as an > >> parameter to be32_to_cpup().

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Viresh Kumar
On 21 March 2013 15:16, Vinod Koul wrote: > On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: >> In of_dma_controller_register() routine we are calling of_get_property() as >> an >> parameter to be32_to_cpup(). In case the property doesn't exist we will get a >> crash. >> >> This

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Vinod Koul
On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: > In of_dma_controller_register() routine we are calling of_get_property() as an > parameter to be32_to_cpup(). In case the property doesn't exist we will get a > crash. > > This patch changes this code to check if we got a valid

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Vinod Koul
On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: In of_dma_controller_register() routine we are calling of_get_property() as an parameter to be32_to_cpup(). In case the property doesn't exist we will get a crash. This patch changes this code to check if we got a valid property

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Viresh Kumar
On 21 March 2013 15:16, Vinod Koul vinod.k...@intel.com wrote: On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: In of_dma_controller_register() routine we are calling of_get_property() as an parameter to be32_to_cpup(). In case the property doesn't exist we will get a crash.

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Vinod Koul
On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote: On 21 March 2013 15:16, Vinod Koul vinod.k...@intel.com wrote: On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: In of_dma_controller_register() routine we are calling of_get_property() as an parameter to

Re: [PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-21 Thread Amit Kucheria
On Thu, Mar 21, 2013 at 4:08 PM, Vinod Koul vinod.k...@intel.com wrote: On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote: On 21 March 2013 15:16, Vinod Koul vinod.k...@intel.com wrote: On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote: In of_dma_controller_register()

[PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-15 Thread Viresh Kumar
In of_dma_controller_register() routine we are calling of_get_property() as an parameter to be32_to_cpup(). In case the property doesn't exist we will get a crash. This patch changes this code to check if we got a valid property first and then runs be32_to_cpup() on it. Signed-off-by: Viresh

[PATCH] DMA: OF: Check properties value before running be32_to_cpup() on it

2013-03-15 Thread Viresh Kumar
In of_dma_controller_register() routine we are calling of_get_property() as an parameter to be32_to_cpup(). In case the property doesn't exist we will get a crash. This patch changes this code to check if we got a valid property first and then runs be32_to_cpup() on it. Signed-off-by: Viresh