Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Steven Rostedt
On Fri, Dec 07, 2012 at 04:24:17PM -0500, Dave Hansen wrote: > > diff -puN /dev/null Documentation/page_owner.c Can we stop putting code into Documentation? We have tools, samples and usr directories. I'm sure this could fit into one of them. -- Steve > --- /dev/null 2012-06-13

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Steven Rostedt
On Fri, Dec 07, 2012 at 02:26:14PM -0800, Andrew Morton wrote: > On Fri, 07 Dec 2012 16:24:17 -0500 > Dave Hansen wrote: > > > To: a...@osdl.org > > It's years since I was called that. "Help me a...@osdl.org. You're my only hope"... > > > From: m...@skynet.ie (Mel Gorman) > > And him that.

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Dave Hansen
On 12/07/2012 02:44 PM, Andrew Morton wrote: > AFACIT that difference was undescribed. I can see that the new version > uses the stack-tracing infrastructure, but the change to > pagetypeinfo_showmixedcount_print() is a mystery. Ahhh, I assume you're talking about this hunk: >> @@ -976,10

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Andrew Morton
On Fri, 07 Dec 2012 14:37:27 -0800 Dave Hansen wrote: > On 12/07/2012 02:26 PM, Andrew Morton wrote:\ > > I have cunningly divined the intention of your update and have queued > > the below incremental. The change to > > pagetypeinfo_showmixedcount_print() was a surprise. What's that there > >

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Dave Hansen
On 12/07/2012 02:26 PM, Andrew Morton wrote:\ > I have cunningly divined the intention of your update and have queued > the below incremental. The change to > pagetypeinfo_showmixedcount_print() was a surprise. What's that there > for? Do you mean to ask why it's being modified at all here in

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Andrew Morton
On Fri, 07 Dec 2012 16:24:17 -0500 Dave Hansen wrote: > To: a...@osdl.org It's years since I was called that. > From: m...@skynet.ie (Mel Gorman) And him that. I have cunningly divined the intention of your update and have queued the below incremental. The change to

[PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Dave Hansen
From: m...@skynet.ie (Mel Gorman) PAGE_OWNER tracks free pages by setting page->order to -1. However, it is set during __free_pages() which is not the only free path as __pagevec_free() and free_compound_page() do not go through __free_pages(). This leads to a situation where free pages are

[PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Dave Hansen
From: m...@skynet.ie (Mel Gorman) PAGE_OWNER tracks free pages by setting page-order to -1. However, it is set during __free_pages() which is not the only free path as __pagevec_free() and free_compound_page() do not go through __free_pages(). This leads to a situation where free pages are

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Andrew Morton
On Fri, 07 Dec 2012 16:24:17 -0500 Dave Hansen d...@linux.vnet.ibm.com wrote: To: a...@osdl.org It's years since I was called that. From: m...@skynet.ie (Mel Gorman) And him that. I have cunningly divined the intention of your update and have queued the below incremental. The change to

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Dave Hansen
On 12/07/2012 02:26 PM, Andrew Morton wrote:\ I have cunningly divined the intention of your update and have queued the below incremental. The change to pagetypeinfo_showmixedcount_print() was a surprise. What's that there for? Do you mean to ask why it's being modified at all here in this

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Andrew Morton
On Fri, 07 Dec 2012 14:37:27 -0800 Dave Hansen d...@linux.vnet.ibm.com wrote: On 12/07/2012 02:26 PM, Andrew Morton wrote:\ I have cunningly divined the intention of your update and have queued the below incremental. The change to pagetypeinfo_showmixedcount_print() was a surprise.

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Dave Hansen
On 12/07/2012 02:44 PM, Andrew Morton wrote: AFACIT that difference was undescribed. I can see that the new version uses the stack-tracing infrastructure, but the change to pagetypeinfo_showmixedcount_print() is a mystery. Ahhh, I assume you're talking about this hunk: @@ -976,10 +976,7 @@

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Steven Rostedt
On Fri, Dec 07, 2012 at 02:26:14PM -0800, Andrew Morton wrote: On Fri, 07 Dec 2012 16:24:17 -0500 Dave Hansen d...@linux.vnet.ibm.com wrote: To: a...@osdl.org It's years since I was called that. Help me a...@osdl.org. You're my only hope... From: m...@skynet.ie (Mel Gorman) And

Re: [PATCH] Debugging: Keep track of page owners

2012-12-07 Thread Steven Rostedt
On Fri, Dec 07, 2012 at 04:24:17PM -0500, Dave Hansen wrote: diff -puN /dev/null Documentation/page_owner.c Can we stop putting code into Documentation? We have tools, samples and usr directories. I'm sure this could fit into one of them. -- Steve --- /dev/null 2012-06-13 15:09:09.708529931