Re: [PATCH] Device tree binding for Avago APDS990X light sensor

On Wed, Dec 27, 2017 at 09:01:47PM +0100, Pavel Machek wrote: > Hi! > > > > +Required properties: > > > +- compatible: "avago,apds990x" > > > +- reg: address on the I2C bus > > > +- interrupts: external interrupt line number > > > +- Vdd-supply: power supply for VDD > > > +- Vled-supply: power

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

On Wed, Dec 27, 2017 at 09:01:47PM +0100, Pavel Machek wrote: > Hi! > > > > +Required properties: > > > +- compatible: "avago,apds990x" > > > +- reg: address on the I2C bus > > > +- interrupts: external interrupt line number > > > +- Vdd-supply: power supply for VDD > > > +- Vled-supply: power

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

On Wed, Dec 27, 2017 at 07:50:42PM +0100, Filip Matijević wrote: > Hi Sakari, > > and thank you for your input - I've added a few comments below. > > On 12/27/2017 07:00 PM, Sakari Ailus wrote: > > Hi Pavel, > > > > Thanks for the patch. Please see my comments below. > > > > On Wed, Dec 27,

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

On Wed, Dec 27, 2017 at 07:50:42PM +0100, Filip Matijević wrote: > Hi Sakari, > > and thank you for your input - I've added a few comments below. > > On 12/27/2017 07:00 PM, Sakari Ailus wrote: > > Hi Pavel, > > > > Thanks for the patch. Please see my comments below. > > > > On Wed, Dec 27,

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

Hi! > > +Required properties: > > +- compatible: "avago,apds990x" > > +- reg: address on the I2C bus > > +- interrupts: external interrupt line number > > +- Vdd-supply: power supply for VDD > > +- Vled-supply: power supply for LEDA > > AFAIK the custom is to use lower case letters for regulator

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

Hi! > > +Required properties: > > +- compatible: "avago,apds990x" > > +- reg: address on the I2C bus > > +- interrupts: external interrupt line number > > +- Vdd-supply: power supply for VDD > > +- Vled-supply: power supply for LEDA > > AFAIK the custom is to use lower case letters for regulator

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

Hi Sakari, and thank you for your input - I've added a few comments below. On 12/27/2017 07:00 PM, Sakari Ailus wrote: > Hi Pavel, > > Thanks for the patch. Please see my comments below. > > On Wed, Dec 27, 2017 at 10:18:28AM +0100, Pavel Machek wrote: >> From: Filip Matijević

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

Hi Sakari, and thank you for your input - I've added a few comments below. On 12/27/2017 07:00 PM, Sakari Ailus wrote: > Hi Pavel, > > Thanks for the patch. Please see my comments below. > > On Wed, Dec 27, 2017 at 10:18:28AM +0100, Pavel Machek wrote: >> From: Filip Matijević >> >> This

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

Hi Pavel, Thanks for the patch. Please see my comments below. On Wed, Dec 27, 2017 at 10:18:28AM +0100, Pavel Machek wrote: > From: Filip Matijević > > This prepares binding for light sensor used in Nokia N9. > > Signed-off-by: Filip Matijević

Re: [PATCH] Device tree binding for Avago APDS990X light sensor

Hi Pavel, Thanks for the patch. Please see my comments below. On Wed, Dec 27, 2017 at 10:18:28AM +0100, Pavel Machek wrote: > From: Filip Matijević > > This prepares binding for light sensor used in Nokia N9. > > Signed-off-by: Filip Matijević > Signed-off-by: Pavel machek > > --- > >

[PATCH] Device tree binding for Avago APDS990X light sensor

From: Filip Matijević This prepares binding for light sensor used in Nokia N9. Signed-off-by: Filip Matijević Signed-off-by: Pavel machek --- Patches to convert APDS990X driver to device tree and to switch to iio are

[PATCH] Device tree binding for Avago APDS990X light sensor

From: Filip Matijević This prepares binding for light sensor used in Nokia N9. Signed-off-by: Filip Matijević Signed-off-by: Pavel machek --- Patches to convert APDS990X driver to device tree and to switch to iio are available. diff --git