Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-08 Thread Len Brown
On Tue, Mar 8, 2016 at 7:14 AM, Thomas Renninger wrote: > On Monday, March 07, 2016 07:50:57 PM Len Brown wrote: >> > But with Broadwell-EP processor (E5-2687W v4) the CPU will not enter turbo >> > modes if this value is not set to performance >> >> BDX-EP supports HWP. >> Are

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-08 Thread Len Brown
On Tue, Mar 8, 2016 at 7:14 AM, Thomas Renninger wrote: > On Monday, March 07, 2016 07:50:57 PM Len Brown wrote: >> > But with Broadwell-EP processor (E5-2687W v4) the CPU will not enter turbo >> > modes if this value is not set to performance >> >> BDX-EP supports HWP. >> Are these failing

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-08 Thread Thomas Renninger
On Monday, March 07, 2016 07:50:57 PM Len Brown wrote: > > But with Broadwell-EP processor (E5-2687W v4) the CPU will not enter turbo > > modes if this value is not set to performance > > BDX-EP supports HWP. > Are these failing machines running in HWP mode? > > (On BDX-EP, and only on BDX-EP,

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-08 Thread Thomas Renninger
On Monday, March 07, 2016 07:50:57 PM Len Brown wrote: > > But with Broadwell-EP processor (E5-2687W v4) the CPU will not enter turbo > > modes if this value is not set to performance > > BDX-EP supports HWP. > Are these failing machines running in HWP mode? > > (On BDX-EP, and only on BDX-EP,

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-07 Thread Len Brown
> But with Broadwell-EP processor (E5-2687W v4) the CPU will not enter turbo > modes > if this value is not set to performance BDX-EP supports HWP. Are these failing machines running in HWP mode? (On BDX-EP, and only on BDX-EP, EPB acts to set the BIAS for HWP, because that processor doesn't

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-07 Thread Len Brown
> But with Broadwell-EP processor (E5-2687W v4) the CPU will not enter turbo > modes > if this value is not set to performance BDX-EP supports HWP. Are these failing machines running in HWP mode? (On BDX-EP, and only on BDX-EP, EPB acts to set the BIAS for HWP, because that processor doesn't

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-04 Thread Rafael J. Wysocki
Hi, On Fri, Mar 4, 2016 at 9:37 AM, Thomas Renninger wrote: > On Wednesday, March 02, 2016 01:26:18 AM Rafael J. Wysocki wrote: >> On Tuesday, March 01, 2016 01:17:37 PM Thomas Renninger wrote: >> > > > if (!cpu_has(c, X86_FEATURE_EPB))z >> > > > >> > > >

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-04 Thread Rafael J. Wysocki
Hi, On Fri, Mar 4, 2016 at 9:37 AM, Thomas Renninger wrote: > On Wednesday, March 02, 2016 01:26:18 AM Rafael J. Wysocki wrote: >> On Tuesday, March 01, 2016 01:17:37 PM Thomas Renninger wrote: >> > > > if (!cpu_has(c, X86_FEATURE_EPB))z >> > > > >> > > > return; >> > > >

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-04 Thread Thomas Renninger
On Wednesday, March 02, 2016 01:26:18 AM Rafael J. Wysocki wrote: > On Tuesday, March 01, 2016 01:17:37 PM Thomas Renninger wrote: > > > > if (!cpu_has(c, X86_FEATURE_EPB))z > > > > > > > > return; > > > > > > > > @@ -387,10 +391,8 @@ static void

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-04 Thread Thomas Renninger
On Wednesday, March 02, 2016 01:26:18 AM Rafael J. Wysocki wrote: > On Tuesday, March 01, 2016 01:17:37 PM Thomas Renninger wrote: > > > > if (!cpu_has(c, X86_FEATURE_EPB))z > > > > > > > > return; > > > > > > > > @@ -387,10 +391,8 @@ static void

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-01 Thread Rafael J. Wysocki
On Tuesday, March 01, 2016 01:17:37 PM Thomas Renninger wrote: > On Saturday, February 27, 2016 12:15:47 AM Rafael J. Wysocki wrote: > > On Friday, February 26, 2016 05:38:00 PM Thomas Renninger wrote: > > > The assumption that BIOSes never want to have this register being set to > > > full

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-01 Thread Rafael J. Wysocki
On Tuesday, March 01, 2016 01:17:37 PM Thomas Renninger wrote: > On Saturday, February 27, 2016 12:15:47 AM Rafael J. Wysocki wrote: > > On Friday, February 26, 2016 05:38:00 PM Thomas Renninger wrote: > > > The assumption that BIOSes never want to have this register being set to > > > full

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-01 Thread Thomas Renninger
On Saturday, February 27, 2016 12:15:47 AM Rafael J. Wysocki wrote: > On Friday, February 26, 2016 05:38:00 PM Thomas Renninger wrote: > > The assumption that BIOSes never want to have this register being set to > > full performance (zero) is wrong. > > > > While wrongly overruling this BIOS

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-03-01 Thread Thomas Renninger
On Saturday, February 27, 2016 12:15:47 AM Rafael J. Wysocki wrote: > On Friday, February 26, 2016 05:38:00 PM Thomas Renninger wrote: > > The assumption that BIOSes never want to have this register being set to > > full performance (zero) is wrong. > > > > While wrongly overruling this BIOS

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-02-26 Thread Rafael J. Wysocki
On Friday, February 26, 2016 05:38:00 PM Thomas Renninger wrote: > The assumption that BIOSes never want to have this register being set to > full performance (zero) is wrong. > > While wrongly overruling this BIOS setting and set it from performance > to normal did not hurt that much, because

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-02-26 Thread Rafael J. Wysocki
On Friday, February 26, 2016 05:38:00 PM Thomas Renninger wrote: > The assumption that BIOSes never want to have this register being set to > full performance (zero) is wrong. > > While wrongly overruling this BIOS setting and set it from performance > to normal did not hurt that much, because

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-02-26 Thread Thomas Renninger
This in fact is a re-send, including x86 maintainers. Even this is a PM (Power Management) issue, the code is in the x86 architecture paths. >From last submit: > > Patch is against latest linux-pm kernel. > > Rafael: Can you queue this one up, please. > Well, I'm not an x86 arch maintainer. >

Re: [PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-02-26 Thread Thomas Renninger
This in fact is a re-send, including x86 maintainers. Even this is a PM (Power Management) issue, the code is in the x86 architecture paths. >From last submit: > > Patch is against latest linux-pm kernel. > > Rafael: Can you queue this one up, please. > Well, I'm not an x86 arch maintainer. >

[PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-02-26 Thread Thomas Renninger
The assumption that BIOSes never want to have this register being set to full performance (zero) is wrong. While wrongly overruling this BIOS setting and set it from performance to normal did not hurt that much, because nobody really knew the effects inside Intel processors. But with

[PATCH] Do not modify MSR_IA32_ENERGY_PERF_BIAS in kernel

2016-02-26 Thread Thomas Renninger
The assumption that BIOSes never want to have this register being set to full performance (zero) is wrong. While wrongly overruling this BIOS setting and set it from performance to normal did not hurt that much, because nobody really knew the effects inside Intel processors. But with