Re: [PATCH] Do not use arbitrary large movablecore to calculate kernelcore

2015-04-02 Thread Zhihui Zhang
If you specify movablecore > totalpages, required_kernelcore will end up with a big number because corepages is an unsigned integer. If so, the following nested is a waste of time. But I see your point. -Zhihui On Wed, Apr 1, 2015 at 7:00 PM, Mel Gorman wrote: > On Sat, Mar 28, 2015 at

Re: [PATCH] Do not use arbitrary large movablecore to calculate kernelcore

2015-04-02 Thread Zhihui Zhang
If you specify movablecore totalpages, required_kernelcore will end up with a big number because corepages is an unsigned integer. If so, the following nested is a waste of time. But I see your point. -Zhihui On Wed, Apr 1, 2015 at 7:00 PM, Mel Gorman mgor...@suse.de wrote: On Sat, Mar 28,

Re: [PATCH] Do not use arbitrary large movablecore to calculate kernelcore

2015-04-01 Thread Mel Gorman
On Sat, Mar 28, 2015 at 11:36:02PM -0400, Zhihui Zhang wrote: > If kernelcore is not set, then we are working with a very large kernelcore > for nothing - no movable zone will be created. If kernelcore is set, > then it is not respected at all. > > Signed-off-by: Zhihui Zhang I'm confused. What

Re: [PATCH] Do not use arbitrary large movablecore to calculate kernelcore

2015-04-01 Thread Mel Gorman
On Sat, Mar 28, 2015 at 11:36:02PM -0400, Zhihui Zhang wrote: If kernelcore is not set, then we are working with a very large kernelcore for nothing - no movable zone will be created. If kernelcore is set, then it is not respected at all. Signed-off-by: Zhihui Zhang zzhs...@gmail.com I'm

[PATCH] Do not use arbitrary large movablecore to calculate kernelcore

2015-03-28 Thread Zhihui Zhang
If kernelcore is not set, then we are working with a very large kernelcore for nothing - no movable zone will be created. If kernelcore is set, then it is not respected at all. Signed-off-by: Zhihui Zhang --- mm/page_alloc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH] Do not use arbitrary large movablecore to calculate kernelcore

2015-03-28 Thread Zhihui Zhang
If kernelcore is not set, then we are working with a very large kernelcore for nothing - no movable zone will be created. If kernelcore is set, then it is not respected at all. Signed-off-by: Zhihui Zhang zzhs...@gmail.com --- mm/page_alloc.c | 6 +- 1 file changed, 5 insertions(+), 1