Re: [PATCH] Documentation/firmware_class/firmware_sample_driver.c

2007-06-29 Thread Anders Blomdell
Satyam Sharma wrote: > Hi, > > [ It's good that you're trying to fix this, code in documentation should > be setting standards, clearly. ] > > On 6/27/07, Anders Blomdell <[EMAIL PROTECTED]> wrote: >> [...] >> Minor modifications to make the example load and unload without Oops >> [...] >> stati

Re: [PATCH] Documentation/firmware_class/firmware_sample_driver.c

2007-06-28 Thread Satyam Sharma
Hi, [ It's good that you're trying to fix this, code in documentation should be setting standards, clearly. ] On 6/27/07, Anders Blomdell <[EMAIL PROTECTED]> wrote: [...] Minor modifications to make the example load and unload without Oops [...] static int sample_init(void) { - device_i

Re: [PATCH] Documentation/firmware_class/firmware_sample_driver.c

2007-06-28 Thread Anders Blomdell
Marcel Holtmann wrote: > Hi Anders, > >> Signed-off-by: Anders Blomdell <[EMAIL PROTECTED]> >> >> Minor modifications to make the example load and unload without Oops >> >> This is what unpatched version generates with 2.6.21.3 >> >> kernel: Oops: [#2] >> ... >> kernel: Call Trace: >> kernel:

Re: [PATCH] Documentation/firmware_class/firmware_sample_driver.c

2007-06-27 Thread Marcel Holtmann
Hi Anders, > Signed-off-by: Anders Blomdell <[EMAIL PROTECTED]> > > Minor modifications to make the example load and unload without Oops > > This is what unpatched version generates with 2.6.21.3 > > kernel: Oops: [#2] > ... > kernel: Call Trace: > kernel: [] sysfs_create_dir+0x49/0x63 >

[PATCH] Documentation/firmware_class/firmware_sample_driver.c

2007-06-27 Thread Anders Blomdell
Signed-off-by: Anders Blomdell <[EMAIL PROTECTED]> Minor modifications to make the example load and unload without Oops This is what unpatched version generates with 2.6.21.3 kernel: Oops: [#2] ... kernel: Call Trace: kernel: [] sysfs_create_dir+0x49/0x63 kernel: [] kobject_shadow_add+0xd