Re: [PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2014-11-06 Thread Steven Rostedt
Cleaning out my inbox I find things that are fun to read. On Mon, 2 Sep 2013 18:02:47 +0100 Zoltan Kiss wrote: > Hi, > > I'm not very familiar with the tracing framework, but I will try to > comment on your questions. > > On 25/08/13 09:59, Rob Landley wrote: > > On 08/22/2013 04:49:31 PM, Zo

Re: [PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2013-09-02 Thread Steven Rostedt
On Mon, 2 Sep 2013 18:02:47 +0100 Zoltan Kiss wrote: > > Why? (Both why do you need to #include a header outside a multiple > > inclusion guard, and why is the additional header needed at all in > > _every_ subsystem trace header?) > I see only one inclusion guard here, the one above. define_tra

Re: [PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2013-09-02 Thread Zoltan Kiss
Hi, I'm not very familiar with the tracing framework, but I will try to comment on your questions. On 25/08/13 09:59, Rob Landley wrote: On 08/22/2013 04:49:31 PM, Zoltan Kiss wrote: +#if !defined(_TRACE_SUBSYS_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_SUBSYS_H But this makes

Re: [PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2013-08-27 Thread Jiri Kosina
On Sat, 24 Aug 2013, Mathieu Desnoyers wrote: > * Zoltan Kiss (zoltan.k...@citrix.com) wrote: > > The sample missed the moving of the header files into the events > > subdirectory. > > I've also extended it based on the existing headers, and mentioned the tiny > > but important role of CREATE_TRA

Re: [PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2013-08-25 Thread Rob Landley
On 08/22/2013 04:49:31 PM, Zoltan Kiss wrote: The sample missed the moving of the header files into the events subdirectory. I've also extended it based on the existing headers, and mentioned the tiny but important role of CREATE_TRACE_POINTS. Signed-off-by: Zoltan Kiss --- Documentation/t

Re: [PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2013-08-24 Thread Mathieu Desnoyers
* Zoltan Kiss (zoltan.k...@citrix.com) wrote: > The sample missed the moving of the header files into the events subdirectory. > I've also extended it based on the existing headers, and mentioned the tiny > but important role of CREATE_TRACE_POINTS. Given that we expect tracepoints to be used thou

[PATCH] Documentation/trace: Correcting and extending tracepoint documentation

2013-08-22 Thread Zoltan Kiss
The sample missed the moving of the header files into the events subdirectory. I've also extended it based on the existing headers, and mentioned the tiny but important role of CREATE_TRACE_POINTS. Signed-off-by: Zoltan Kiss --- Documentation/trace/tracepoints.txt | 19 +-- 1 f