Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-09-07 Thread Marco Elver
On Fri, Sep 04, 2020 at 12:22PM +0800, David Gow wrote: [...] > > This is a good point -- renaming files is definitely a pain. It's > obviously my hope that KUnit sticks around long enough that it's not > being added/removed as a dependency too often, particularly for the > unit tests, so "_kunit"

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-09-03 Thread David Gow
On Tue, Sep 1, 2020 at 8:23 PM Marco Elver wrote: > > On Tue, 1 Sep 2020 at 07:31, David Gow wrote: > > On Tue, Sep 1, 2020 at 7:47 AM Kees Cook wrote: > > > On Fri, Aug 28, 2020 at 12:17:05AM +0800, David Gow wrote: > > > > On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote: > [...] > > > > I g

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-09-01 Thread Marco Elver
On Tue, 1 Sep 2020 at 07:31, David Gow wrote: > On Tue, Sep 1, 2020 at 7:47 AM Kees Cook wrote: > > On Fri, Aug 28, 2020 at 12:17:05AM +0800, David Gow wrote: > > > On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote: [...] > > I guess there are two audiences to cater for: > 1. Test authors, who m

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-08-31 Thread David Gow
On Tue, Sep 1, 2020 at 7:47 AM Kees Cook wrote: > > On Fri, Aug 28, 2020 at 12:17:05AM +0800, David Gow wrote: > > On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote: > > > Just an idea: Maybe the names are also an opportunity to distinguish > > > real _unit_ style tests and then the rarer integra

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-08-31 Thread Kees Cook
On Fri, Aug 28, 2020 at 12:17:05AM +0800, David Gow wrote: > On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote: > > Just an idea: Maybe the names are also an opportunity to distinguish > > real _unit_ style tests and then the rarer integration-style tests. I > > personally prefer using the more ge

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-08-27 Thread Brendan Higgins
On Thu, Aug 27, 2020 at 11:28 AM Marco Elver wrote: > > On Thu, 27 Aug 2020 at 18:17, David Gow wrote: > [...] > > > First of all, thanks for the talk yesterday! I only looked at this > > > because somebody pasted the LKML link. :-) > > > > No worries! Clearly this document needed linking -- even

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-08-27 Thread Marco Elver
On Thu, 27 Aug 2020 at 18:17, David Gow wrote: [...] > > First of all, thanks for the talk yesterday! I only looked at this > > because somebody pasted the LKML link. :-) > > No worries! Clearly this document needed linking -- even I was > starting to suspect the reason no-one was complaining abou

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-08-27 Thread David Gow
On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote: > > On Thu, Jul 02, 2020 at 12:14AM -0700, David Gow wrote: > > As discussed in [1], KUnit tests have hitherto not had a particularly > > consistent naming scheme. This adds documentation outlining how tests > > and test suites should be named, in

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-08-27 Thread Marco Elver
On Thu, Jul 02, 2020 at 12:14AM -0700, David Gow wrote: > As discussed in [1], KUnit tests have hitherto not had a particularly > consistent naming scheme. This adds documentation outlining how tests > and test suites should be named, including how those names should be > used in Kconfig entries an

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-07-31 Thread Brendan Higgins
On Thu, Jul 2, 2020 at 12:14 AM David Gow wrote: > > As discussed in [1], KUnit tests have hitherto not had a particularly > consistent naming scheme. This adds documentation outlining how tests > and test suites should be named, including how those names should be > used in Kconfig entries and fi

[PATCH] Documentation: kunit: Add naming guidelines

2020-07-02 Thread David Gow
As discussed in [1], KUnit tests have hitherto not had a particularly consistent naming scheme. This adds documentation outlining how tests and test suites should be named, including how those names should be used in Kconfig entries and filenames. [1]: https://lore.kernel.org/linux-kselftest/20200

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-06-22 Thread Kees Cook
On Fri, Jun 19, 2020 at 10:49:44PM -0700, David Gow wrote: > As discussed in [1], KUnit tests have hitherto not had a particularly > consistent naming scheme. This adds documentation outlining how tests > and test suites should be named, including how those names should be > used in Kconfig entries

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-06-22 Thread Brendan Higgins
I imagine +Theodore Ts'o might have some thoughts on this. +Bird, Timothy - Figured you might be interested since I think this might pertain to the KTAP discussion. On Fri, Jun 19, 2020 at 10:50 PM David Gow wrote: > > As discussed in [1], KUnit tests have hitherto not had a particularly > consi

Re: [PATCH] Documentation: kunit: Add naming guidelines

2020-06-21 Thread Randy Dunlap
Hi-- On 6/19/20 10:49 PM, David Gow wrote: > Documentation/dev-tools/kunit/index.rst | 1 + > Documentation/dev-tools/kunit/style.rst | 139 > 2 files changed, 140 insertions(+) > create mode 100644 Documentation/dev-tools/kunit/style.rst > > diff --git a/Documentatio

[PATCH] Documentation: kunit: Add naming guidelines

2020-06-19 Thread David Gow
As discussed in [1], KUnit tests have hitherto not had a particularly consistent naming scheme. This adds documentation outlining how tests and test suites should be named, including how those names should be used in Kconfig entries and filenames. [1]: https://lore.kernel.org/linux-kselftest/20200