Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-29 Thread Michael Kerrisk (man-pages)
Hi David, On 02/29/2016 10:22 PM, Davidlohr Bueso wrote: > On Sun, 28 Feb 2016, Michael Kerrisk wrote: > >> Linux also updates sempid for SETVAL operations and semaphore >> adjustments. However, somewhat inconsistently, it does not >> update sempid for SETALL operations.

Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-29 Thread Davidlohr Bueso
On Sun, 28 Feb 2016, Michael Kerrisk wrote: Linux also updates sempid for SETVAL operations and semaphore adjustments. However, somewhat inconsistently, it does not update sempid for SETALL operations. While the SETALL behavior might be viewed as a bug, the behavi

Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-28 Thread Michael Kerrisk
On Sat, Feb 27, 2016 at 9:42 AM, PrasannaKumar Muralidharan wrote: > Agreed. Is it better to change the man page and document the behaviour? Requoting text I just added to the Bugzilla report to explain why the right approach seems to be to document, rather than change this behavior: So, given t

Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-27 Thread PrasannaKumar Muralidharan
Agreed. Is it better to change the man page and document the behaviour? Regards, PrasannaKumar

Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-26 Thread Davidlohr Bueso
On Fri, 26 Feb 2016, Davidlohr Bueso wrote: Furthermore, semop.2 is very explicit about sempid. That said, I am also weary of this change because we've been setting semval for semctl for so long. s/semval/sempid :)

Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-26 Thread Davidlohr Bueso
On Fri, 26 Feb 2016, Manfred Spraul wrote: This is a user-visible change, adding mtk. Hi, On 02/26/2016 01:21 PM, PrasannaKumar Muralidharan wrote: From: PrasannaKumar Muralidharan As described in bug #112271 (bugzilla.kernel.org/show_bug.cgi?id=112271) don't set sempid in semctl syscall. S

Re: [PATCH] Don't set sempid in semctl syscall.

2016-02-26 Thread Manfred Spraul
Hi, On 02/26/2016 01:21 PM, PrasannaKumar Muralidharan wrote: From: PrasannaKumar Muralidharan As described in bug #112271 (bugzilla.kernel.org/show_bug.cgi?id=112271) don't set sempid in semctl syscall. Set sempid only when semop is called. I disagree with the bug report: sempid is (and alw

[PATCH] Don't set sempid in semctl syscall.

2016-02-26 Thread PrasannaKumar Muralidharan
From: PrasannaKumar Muralidharan As described in bug #112271 (bugzilla.kernel.org/show_bug.cgi?id=112271) don't set sempid in semctl syscall. Set sempid only when semop is called. Signed-off-by: PrasannaKumar Muralidharan --- ipc/sem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ipc/sem