Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2015-01-05 Thread Bas Peters
Dear Tilman, Thanks for the feedback. I made a lot of mistakes... Sorry for wasting your time with this patch. I'll work on improving it and dividing it up into smaller chunks as recommended by other kernel developers and will try to fix the issues. With kind regards, Bas 2015-01-03 16:01 GMT+

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2015-01-03 Thread Tilman Schmidt
[I only just noticed that my first reply got terribly mangled by my mailer, so here it is again, hopefully more readable this time.] Hello Bas, I have several objections to your patch. Am 31.12.2014 um 18:34 schrieb Bas Peters: > I have not been able to test the code as I do not have access to t

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2015-01-01 Thread Tilman Schmidt
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Bas, I have several objections to your patch. Am 31.12.2014 um 18:34 schrieb Bas Peters: > I have not been able to test the code as I do not have access to > the hardware but since no new features were really added I don't > think that should p

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Jeremiah Mahler
Bas, On Wed, Dec 31, 2014 at 07:04:30PM +0100, Bas Peters wrote: > 2014-12-31 18:49 GMT+01:00 Jeremiah Mahler : > > Bas, > > > > On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote: > >> Fixed many checkpatch.pl complaints, ranging from whitespace issues to > >> reportedly deprecated functi

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Bas Peters
2014-12-31 18:49 GMT+01:00 Jeremiah Mahler : > Bas, > > On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote: >> Fixed many checkpatch.pl complaints, ranging from whitespace issues to >> reportedly deprecated function and macro usage. >> > One patch should fix one type of problem. This needs

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Jeremiah Mahler
Bas, On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote: > Fixed many checkpatch.pl complaints, ranging from whitespace issues to > reportedly deprecated function and macro usage. > One patch should fix one type of problem. This needs to be broken up in to individual patches. > I have n

[PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Bas Peters
Fixed many checkpatch.pl complaints, ranging from whitespace issues to reportedly deprecated function and macro usage. I have not been able to test the code as I do not have access to the hardware but since no new features were really added I don't think that should pose a problem. There are stil