Re: [PATCH] Drop -Wdeclaration-after-statement

2019-03-12 Thread Andrew Morton
> > > > > > It is not good in my opinion to stick to -Wdeclaration-after-statement. > > > > Why? > > It is useful to have declarations mixed with code. Am inclined to agree. Maybe. > Once kernel will switch to C99 or C11 it _will_ be used to the point of > requiring it on the coding style

Re: [PATCH] Drop -Wdeclaration-after-statement

2019-03-12 Thread Alexey Dobriyan
On Tue, Mar 12, 2019 at 12:50:17PM -0700, Andrew Morton wrote: > On Tue, 12 Mar 2019 20:24:47 +0300 Alexey Dobriyan > wrote: > > > On Mon, Mar 11, 2019 at 05:38:45PM -0700, Andrew Morton wrote: > > > On Sun, 10 Mar 2019 16:35:35 +0300 Alexey Dobriyan > > > wrote: > > > > > > > Newly added

Re: [PATCH] Drop -Wdeclaration-after-statement

2019-03-12 Thread Alexey Dobriyan
On Tue, Mar 12, 2019 at 12:50:17PM -0700, Andrew Morton wrote: > On Tue, 12 Mar 2019 20:24:47 +0300 Alexey Dobriyan > wrote: > > > On Mon, Mar 11, 2019 at 05:38:45PM -0700, Andrew Morton wrote: > > > On Sun, 10 Mar 2019 16:35:35 +0300 Alexey Dobriyan > > > wrote: > > > > > > > Newly added

Re: [PATCH] Drop -Wdeclaration-after-statement

2019-03-12 Thread Andrew Morton
On Tue, 12 Mar 2019 20:24:47 +0300 Alexey Dobriyan wrote: > On Mon, Mar 11, 2019 at 05:38:45PM -0700, Andrew Morton wrote: > > On Sun, 10 Mar 2019 16:35:35 +0300 Alexey Dobriyan > > wrote: > > > > > Newly added static_assert() is formally a declaration, which will give > > > a warning if used

Re: [PATCH] Drop -Wdeclaration-after-statement

2019-03-12 Thread Alexey Dobriyan
On Mon, Mar 11, 2019 at 05:38:45PM -0700, Andrew Morton wrote: > On Sun, 10 Mar 2019 16:35:35 +0300 Alexey Dobriyan > wrote: > > > Newly added static_assert() is formally a declaration, which will give > > a warning if used in the middle of the function. > > > > ... > > > > --- a/Makefile > >

Re: [PATCH] Drop -Wdeclaration-after-statement

2019-03-11 Thread Andrew Morton
On Sun, 10 Mar 2019 16:35:35 +0300 Alexey Dobriyan wrote: > Newly added static_assert() is formally a declaration, which will give > a warning if used in the middle of the function. > > ... > > --- a/Makefile > +++ b/Makefile > @@ -792,9 +792,6 @@ endif > # arch Makefile may override CC so

[PATCH] Drop -Wdeclaration-after-statement

2019-03-10 Thread Alexey Dobriyan
Newly added static_assert() is formally a declaration, which will give a warning if used in the middle of the function. Signed-off-by: Alexey Dobriyan --- Makefile |3 --- 1 file changed, 3 deletions(-) --- a/Makefile +++ b/Makefile @@ -792,9 +792,6 @@ endif # arch Makefile may override