Re: [PATCH] EDAC: sb_edac: simplify switch statement

2020-09-10 Thread Borislav Petkov
On Tue, Sep 08, 2020 at 10:08:28PM +, Luck, Tony wrote: > [Boris: Pushed to edac-misc and edac-for-next branches in RAS tree] Yap, looks good. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

RE: [PATCH] EDAC: sb_edac: simplify switch statement

2020-09-08 Thread Luck, Tony
> However by initializing the type to DEV_UNKNOWN the 3 case can be > removed from the switch, saving a comparison and jump. > > Signed-off-by: Tom Rix Applied. Thanks. -Tony [Boris: Pushed to edac-misc and edac-for-next branches in RAS tree]

Re: [PATCH] EDAC: sb_edac: simplify switch statement

2020-09-07 Thread Nathan Chancellor
On Mon, Sep 07, 2020 at 08:32:25AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analyzer reports this problem > > sb_edac.c:959:2: warning: Undefined or garbage value > returned to caller > return type; > ^~~ > > This is a false positive. > >

[PATCH] EDAC: sb_edac: simplify switch statement

2020-09-07 Thread trix
From: Tom Rix clang static analyzer reports this problem sb_edac.c:959:2: warning: Undefined or garbage value returned to caller return type; ^~~ This is a false positive. However by initializing the type to DEV_UNKNOWN the 3 case can be removed from the switch,