Re: [PATCH] Eliminate result signage problem in asm-x86_64/bitops.h

2007-08-15 Thread Chuck Lever
I apologize for sending a separate cover letter for a single patch. Andi Kleen wrote: On Wed, Aug 15, 2007 at 05:02:47PM -0400, Chuck Lever wrote: The return type of __scanbit() doesn't match the return type of find_{first,next}_bit(). Thus when you construct something like this: boolean

Re: [PATCH] Eliminate result signage problem in asm-x86_64/bitops.h

2007-08-15 Thread Andi Kleen
On Wed, Aug 15, 2007 at 05:02:47PM -0400, Chuck Lever wrote: > The return type of __scanbit() doesn't match the return type of > find_{first,next}_bit(). Thus when you construct something like > this: > >boolean ? __scanbit() : find_first_bit() Why would you want to write this? What is

[PATCH] Eliminate result signage problem in asm-x86_64/bitops.h

2007-08-15 Thread Chuck Lever
The return type of __scanbit() doesn't match the return type of find_{first,next}_bit(). Thus when you construct something like this: boolean ? __scanbit() : find_first_bit() you get an unsigned long result if "boolean" is true, and a signed long result if "boolean" is false. In file

[PATCH] Eliminate result signage problem in asm-x86_64/bitops.h

2007-08-15 Thread Chuck Lever
The return type of __scanbit() doesn't match the return type of find_{first,next}_bit(). Thus when you construct something like this: boolean ? __scanbit() : find_first_bit() you get an unsigned long result if boolean is true, and a signed long result if boolean is false. In file included

Re: [PATCH] Eliminate result signage problem in asm-x86_64/bitops.h

2007-08-15 Thread Andi Kleen
On Wed, Aug 15, 2007 at 05:02:47PM -0400, Chuck Lever wrote: The return type of __scanbit() doesn't match the return type of find_{first,next}_bit(). Thus when you construct something like this: boolean ? __scanbit() : find_first_bit() Why would you want to write this? What is boolean?

Re: [PATCH] Eliminate result signage problem in asm-x86_64/bitops.h

2007-08-15 Thread Chuck Lever
I apologize for sending a separate cover letter for a single patch. Andi Kleen wrote: On Wed, Aug 15, 2007 at 05:02:47PM -0400, Chuck Lever wrote: The return type of __scanbit() doesn't match the return type of find_{first,next}_bit(). Thus when you construct something like this: boolean