Re: [PATCH] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-09 Thread James Smart
ACK -- james s Jesper Juhl wrote: I propose this patch, that simply changes the 'hbqno > LPFC_MAX_HBQS' into 'hbqno >= LPFC_MAX_HBQS' as a possible fix. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/scsi/lpfc/lpfc_sli.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-09 Thread Jesper Juhl
Hi, The Coverity checker noticed that we may overrun a statically allocated array in drivers/scsi/lpfc/lpfc_sli.c::lpfc_sli_hbqbuf_find(). The case is this; In 'struct lpfc_hba' we have #define LPFC_MAX_HBQS 4 ... struct lpfc_hba { ...

[PATCH] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-09 Thread Jesper Juhl
Hi, The Coverity checker noticed that we may overrun a statically allocated array in drivers/scsi/lpfc/lpfc_sli.c::lpfc_sli_hbqbuf_find(). The case is this; In 'struct lpfc_hba' we have #define LPFC_MAX_HBQS 4 ... struct lpfc_hba { ...

Re: [PATCH] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-09 Thread James Smart
ACK -- james s Jesper Juhl wrote: I propose this patch, that simply changes the 'hbqno LPFC_MAX_HBQS' into 'hbqno = LPFC_MAX_HBQS' as a possible fix. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/scsi/lpfc/lpfc_sli.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)