Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-11 Thread Dave Chinner
On Sun, Nov 11, 2018 at 08:36:03AM +0800, hmsjwzb wrote: > Possible unwrapped commit description (prefer a maximum 75 chars per line) NACK. Our preference is (and always has been) for comments to fill the entire 80 columns, just like the rest of the kernel. I have no idea who told you "75 columns

Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread Joe Perches
On Sun, 2018-11-11 at 08:36 +0800, hmsjwzb wrote: > Possible unwrapped commit description (prefer a maximum 75 chars per line) This commit message makes no sense. Do say what you do to the code in the commit description. > Signed-off-by: hmsjwzb > --- > fs/xfs/xfs_acl.c | 4 +-- > fs/xfs/xf

[PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread hmsjwzb
Possible unwrapped commit description (prefer a maximum 75 chars per line) Signed-off-by: hmsjwzb --- fs/xfs/xfs_acl.c | 4 +-- fs/xfs/xfs_aops.c | 73 --- 2 files changed, 39 insertions(+), 38 deletions(-) diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs