Re: [PATCH] Fix failure to resume from initrds

2007-09-14 Thread Pavel Machek
Hi! > From: Nigel Cunningham <[EMAIL PROTECTED]> > > Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads > nonfreezable by default) breaks freezing when attempting to resume from an > initrd, because the init (which is freezeable) spins while waiting for another > thread

[PATCH] Fix failure to resume from initrds

2007-09-14 Thread Rafael J. Wysocki
[Please consider as 2.6.23 material] --- From: Nigel Cunningham <[EMAIL PROTECTED]> Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads nonfreezable by default) breaks freezing when attempting to resume from an initrd, because the init (which is freezeable) spins while wa

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Rafael J. Wysocki
On Tuesday, 11 September 2007 15:41, Nigel Cunningham wrote: > Hi. > > On Tuesday 11 September 2007 23:23:32 Rafael J. Wysocki wrote: > > On Tuesday, 11 September 2007 15:12, Rafael J. Wysocki wrote: > > > On Tuesday, 11 September 2007 13:55, Rafael J. Wysocki wrote: > > > > On Tuesday, 11 Septemb

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Pavel Machek
Hi! > > > Anyway, yes, init is freezable, but should it be? > > > > > > I mean, shouldn't we rather add PF_NOFREEZE to kernel_init()? > > > > Argh, no. PF_NOFREEZE is inherited by the children. > > Umm. All of this is __init code - why is freezability even an issue? We > shouldn't be suspendi

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Linus Torvalds
On Tue, 11 Sep 2007, Rafael J. Wysocki wrote: > > Anyway, yes, init is freezable, but should it be? > > > > I mean, shouldn't we rather add PF_NOFREEZE to kernel_init()? > > Argh, no. PF_NOFREEZE is inherited by the children. Umm. All of this is __init code - why is freezability even an issue

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Nigel Cunningham
Hi. On Tuesday 11 September 2007 23:23:32 Rafael J. Wysocki wrote: > On Tuesday, 11 September 2007 15:12, Rafael J. Wysocki wrote: > > On Tuesday, 11 September 2007 13:55, Rafael J. Wysocki wrote: > > > On Tuesday, 11 September 2007 13:27, Nigel Cunningham wrote: > > > > Hi. > > > > > > > > On Tu

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Rafael J. Wysocki
On Tuesday, 11 September 2007 15:12, Rafael J. Wysocki wrote: > On Tuesday, 11 September 2007 13:55, Rafael J. Wysocki wrote: > > On Tuesday, 11 September 2007 13:27, Nigel Cunningham wrote: > > > Hi. > > > > > > On Tuesday 11 September 2007 21:04:22 Rafael J. Wysocki wrote: > > > > On Tuesday, 11

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Nigel Cunningham
Hi again. On Tuesday 11 September 2007 21:55:06 Rafael J. Wysocki wrote: > On Tuesday, 11 September 2007 13:27, Nigel Cunningham wrote: > > Hi. > > > > On Tuesday 11 September 2007 21:04:22 Rafael J. Wysocki wrote: > > > On Tuesday, 11 September 2007 05:54, Nigel Cunningham wrote: > > > > Hi all.

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Rafael J. Wysocki
On Tuesday, 11 September 2007 13:55, Rafael J. Wysocki wrote: > On Tuesday, 11 September 2007 13:27, Nigel Cunningham wrote: > > Hi. > > > > On Tuesday 11 September 2007 21:04:22 Rafael J. Wysocki wrote: > > > On Tuesday, 11 September 2007 05:54, Nigel Cunningham wrote: > > > > Hi all. > > > > >

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Rafael J. Wysocki
On Tuesday, 11 September 2007 13:27, Nigel Cunningham wrote: > Hi. > > On Tuesday 11 September 2007 21:04:22 Rafael J. Wysocki wrote: > > On Tuesday, 11 September 2007 05:54, Nigel Cunningham wrote: > > > Hi all. > > > > > > Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel >

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Nigel Cunningham
Hi. On Tuesday 11 September 2007 21:04:22 Rafael J. Wysocki wrote: > On Tuesday, 11 September 2007 05:54, Nigel Cunningham wrote: > > Hi all. > > > > Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads > > nonfreezable by default) breaks freezing when attempting to resu

Re: [PATCH] Fix failure to resume from initrds.

2007-09-11 Thread Rafael J. Wysocki
On Tuesday, 11 September 2007 05:54, Nigel Cunningham wrote: > Hi all. > > Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads > nonfreezable by default) breaks freezing when attempting to resume from an > initrd, because the init (which is freezeable) spins while waiting

[PATCH] Fix failure to resume from initrds.

2007-09-10 Thread Nigel Cunningham
Hi all. Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads nonfreezable by default) breaks freezing when attempting to resume from an initrd, because the init (which is freezeable) spins while waiting for another thread to run /linuxrc, but doesn't check whether it has b