On Tue, May 20, 2014 at 11:21:08PM +0200, Lars-Peter Clausen wrote:
> On 05/20/2014 09:16 PM, Tomasz Figa wrote:
> >Still, I'm not too experienced with ALSA and ASoC, so I might be wrong.
> >Mark, what do you think about this?
> Given that there is a patch[1] which removes the whole file I think
On 05/20/2014 09:16 PM, Tomasz Figa wrote:
Hi Rickard,
On 20.05.2014 21:12, Rickard Strandqvist wrote:
Hi Tomasz
What I based my patch on is really because of this line:
if (substream)
snd_pcm_period_elapsed(substream);
Boojin Kim thought that this was needed, if this is true
On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote:
> To me having NULL as either data argument of buffer done callback or
> private_data would be a serious driver bug and IMHO it's better to let
> it crash with a NULL pointer dereference to let someone notice than mask
> it by adding a
On 20.05.2014 21:29, Andrew Eikum wrote:
> On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote:
>> To me having NULL as either data argument of buffer done callback or
>> private_data would be a serious driver bug and IMHO it's better to let
>> it crash with a NULL pointer dereference to
Hi Rickard,
On 20.05.2014 21:12, Rickard Strandqvist wrote:
> Hi Tomasz
>
> What I based my patch on is really because of this line:
> if (substream)
> snd_pcm_period_elapsed(substream);
>
> Boojin Kim thought that this was needed, if this is true anymore..? I
> have not been able to
Hi Tomasz
What I based my patch on is really because of this line:
if (substream)
snd_pcm_period_elapsed(substream);
Boojin Kim thought that this was needed, if this is true anymore..? I
have not been able to immerse myself so much in all patches.
I'm working on about 100 similar
Hi Tomasz
What I based my patch on is really because of this line:
if (substream)
snd_pcm_period_elapsed(substream);
Boojin Kim thought that this was needed, if this is true anymore..? I
have not been able to immerse myself so much in all patches.
I'm working on about 100 similar
Hi Rickard,
On 20.05.2014 21:12, Rickard Strandqvist wrote:
Hi Tomasz
What I based my patch on is really because of this line:
if (substream)
snd_pcm_period_elapsed(substream);
Boojin Kim thought that this was needed, if this is true anymore..? I
have not been able to immerse
On 20.05.2014 21:29, Andrew Eikum wrote:
On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote:
To me having NULL as either data argument of buffer done callback or
private_data would be a serious driver bug and IMHO it's better to let
it crash with a NULL pointer dereference to let
On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote:
To me having NULL as either data argument of buffer done callback or
private_data would be a serious driver bug and IMHO it's better to let
it crash with a NULL pointer dereference to let someone notice than mask
it by adding a
On 05/20/2014 09:16 PM, Tomasz Figa wrote:
Hi Rickard,
On 20.05.2014 21:12, Rickard Strandqvist wrote:
Hi Tomasz
What I based my patch on is really because of this line:
if (substream)
snd_pcm_period_elapsed(substream);
Boojin Kim thought that this was needed, if this is true
On Tue, May 20, 2014 at 11:21:08PM +0200, Lars-Peter Clausen wrote:
On 05/20/2014 09:16 PM, Tomasz Figa wrote:
Still, I'm not too experienced with ALSA and ASoC, so I might be wrong.
Mark, what do you think about this?
Given that there is a patch[1] which removes the whole file I think we
Hi Rickard,
On 15.05.2014 23:57, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> sound/soc/samsung/dma.c | 10
Hi Rickard,
On 15.05.2014 23:57, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
Hi,
Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> sound/soc/samsung/dma.c | 10 ++
> 1 fil ändrad, 6
Hi,
Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
sound/soc/samsung/dma.c | 10
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
sound/soc/samsung/dma.c | 10 ++
1 fil ändrad, 6 tillägg(+), 4 borttagningar(-)
diff --git
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
sound/soc/samsung/dma.c | 10 ++
1 fil ändrad, 6 tillägg(+), 4
18 matches
Mail list logo
