Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Andrew Morton
On Fri, 23 Mar 2007 00:04:07 +0100 Bernhard Walle <[EMAIL PROTECTED]> wrote: > * Andrew Morton <[EMAIL PROTECTED]> [2007-03-22 22:09]: > > On Tue, 20 Mar 2007 16:00:27 +0100 > > Bernhard Walle <[EMAIL PROTECTED]> wrote: > > > > > On IA64, the timer interrupt is not (always?) zero as it is on x86

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Bernhard Walle
* Andrew Morton <[EMAIL PROTECTED]> [2007-03-22 22:09]: > On Tue, 20 Mar 2007 16:00:27 +0100 > Bernhard Walle <[EMAIL PROTECTED]> wrote: > > > On IA64, the timer interrupt is not (always?) zero as it is on x86 > > platforms. > > Also, the timer interrupt is CPU-local. Two things need to be

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Bernhard Walle
Hello, * Thomas Gleixner <[EMAIL PROTECTED]> [2007-03-22 22:23]: > > > Also, the code presently passes the magic IRQ number into the generic IRQ > > code. I wonder if we'd get a more pleasing result if we were to make the > > generic IRQ code call _out_ to the architecture: > > > Then, ia64

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 22:23:21 +0100 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Thu, 2007-03-22 at 14:09 -0700, Andrew Morton wrote: > > I think the term 'timer_interrupt' is a bit generic-sounding. Would it be > > better to call it irqpoll_interrupt? After all, some architecture might > >

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Thomas Gleixner
On Thu, 2007-03-22 at 14:09 -0700, Andrew Morton wrote: > I think the term 'timer_interrupt' is a bit generic-sounding. Would it be > better to call it irqpoll_interrupt? After all, some architecture might > want to use, umm, the keyboard interrupt to trigger IRQ polling ;) Interesting

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Andrew Morton
On Tue, 20 Mar 2007 16:00:27 +0100 Bernhard Walle <[EMAIL PROTECTED]> wrote: > On IA64, the timer interrupt is not (always?) zero as it is on x86 platforms. > Also, the timer interrupt is CPU-local. Two things need to be changed to make > the irqpoll option make also working on IA64: > > o

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Andrew Morton
On Tue, 20 Mar 2007 16:00:27 +0100 Bernhard Walle [EMAIL PROTECTED] wrote: On IA64, the timer interrupt is not (always?) zero as it is on x86 platforms. Also, the timer interrupt is CPU-local. Two things need to be changed to make the irqpoll option make also working on IA64: o Call

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Thomas Gleixner
On Thu, 2007-03-22 at 14:09 -0700, Andrew Morton wrote: I think the term 'timer_interrupt' is a bit generic-sounding. Would it be better to call it irqpoll_interrupt? After all, some architecture might want to use, umm, the keyboard interrupt to trigger IRQ polling ;) Interesting thought,

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 22:23:21 +0100 Thomas Gleixner [EMAIL PROTECTED] wrote: On Thu, 2007-03-22 at 14:09 -0700, Andrew Morton wrote: I think the term 'timer_interrupt' is a bit generic-sounding. Would it be better to call it irqpoll_interrupt? After all, some architecture might want to

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Bernhard Walle
Hello, * Thomas Gleixner [EMAIL PROTECTED] [2007-03-22 22:23]: Also, the code presently passes the magic IRQ number into the generic IRQ code. I wonder if we'd get a more pleasing result if we were to make the generic IRQ code call _out_ to the architecture: Then, ia64 can implement

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Bernhard Walle
* Andrew Morton [EMAIL PROTECTED] [2007-03-22 22:09]: On Tue, 20 Mar 2007 16:00:27 +0100 Bernhard Walle [EMAIL PROTECTED] wrote: On IA64, the timer interrupt is not (always?) zero as it is on x86 platforms. Also, the timer interrupt is CPU-local. Two things need to be changed to make

Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-22 Thread Andrew Morton
On Fri, 23 Mar 2007 00:04:07 +0100 Bernhard Walle [EMAIL PROTECTED] wrote: * Andrew Morton [EMAIL PROTECTED] [2007-03-22 22:09]: On Tue, 20 Mar 2007 16:00:27 +0100 Bernhard Walle [EMAIL PROTECTED] wrote: On IA64, the timer interrupt is not (always?) zero as it is on x86 platforms.

[PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-20 Thread Bernhard Walle
On IA64, the timer interrupt is not (always?) zero as it is on x86 platforms. Also, the timer interrupt is CPU-local. Two things need to be changed to make the irqpoll option make also working on IA64: o Call note_interrupt() also on CPU-local interrupts in __do_IRQ(). o Set a variable

[PATCH] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-20 Thread Bernhard Walle
On IA64, the timer interrupt is not (always?) zero as it is on x86 platforms. Also, the timer interrupt is CPU-local. Two things need to be changed to make the irqpoll option make also working on IA64: o Call note_interrupt() also on CPU-local interrupts in __do_IRQ(). o Set a variable