Re: [PATCH] Fix logical-not-parentheses warning

2015-08-03 Thread Takashi Iwai
On Sun, 02 Aug 2015 11:08:57 +0200, Tomer Barletz wrote: > > This fixes the following warning, that is seen with gcc 5.1: > warning: logical not is only applied to the left hand side of comparison > [-Wlogical-not-parentheses]. > > Signed-off-by: Tomer Barletz Applied, thanks. Takashi > ---

Re: [PATCH] Fix logical-not-parentheses warning

2015-08-02 Thread Joe Perches
On Sun, 2015-08-02 at 02:08 -0700, Tomer Barletz wrote: > This fixes the following warning, that is seen with gcc 5.1: > warning: logical not is only applied to the left hand side of > comparison [-Wlogical-not-parentheses]. [] > diff --git a/sound/pci/oxygen/oxygen_mixer.c [] > @@ -88,7 +88,7 @

[PATCH] Fix logical-not-parentheses warning

2015-08-02 Thread Tomer Barletz
This fixes the following warning, that is seen with gcc 5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz --- sound/pci/oxygen/oxygen_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] Fix logical-not-parentheses warning

2015-08-02 Thread Takashi Iwai
On Sun, 02 Aug 2015 07:43:22 +0200, Tomer Barletz wrote: > > Signed-off-by: Tomer Barletz This is rather a gcc5 problem that doesn't recognize the expression correctly. Though, this change make things worse, so I'm willing to take it. But please give the warning message itself in changelog to

[PATCH] Fix logical-not-parentheses warning

2015-08-01 Thread Tomer Barletz
Signed-off-by: Tomer Barletz --- sound/pci/oxygen/oxygen_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c index 6492bca..4ca1266 100644 --- a/sound/pci/oxygen/oxygen_mixer.c +++ b/sound/pci/oxygen/oxygen_