Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Jens Axboe
On Mon, Feb 28 2005, Dave Olien wrote: > > Just trivial, I think you're missing the final "0" argument > in the __bio_for_each_segment(). Yep indeed, was just a hasty edit... > > On Mon, Feb 28, 2005 at 04:51:28PM +0100, Jens Axboe wrote: > > This should fix it. > > > > Signed-off-by: Jens Axb

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Dave Olien
Just trivial, I think you're missing the final "0" argument in the __bio_for_each_segment(). On Mon, Feb 28, 2005 at 04:51:28PM +0100, Jens Axboe wrote: > This should fix it. > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > > > = mm/highmem.c 1.55 vs edited = > --- 1.55/mm/highmem.c

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Jens Axboe
On Mon, Feb 28 2005, Mark Haverkamp wrote: > On Mon, 2005-02-28 at 16:51 +0100, Jens Axboe wrote: > > On Mon, Feb 28 2005, Mark Haverkamp wrote: > > > On Sat, 2005-02-26 at 13:39 +0100, Jens Axboe wrote: > > > > On Fri, Feb 25 2005, Linus Torvalds wrote: > > > > > > > > > > > > > > > On Fri, 25 F

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Mark Haverkamp
On Mon, 2005-02-28 at 08:13 -0800, Mark Haverkamp wrote: > On Mon, 2005-02-28 at 16:51 +0100, Jens Axboe wrote: > > On Mon, Feb 28 2005, Mark Haverkamp wrote: > > > On Sat, 2005-02-26 at 13:39 +0100, Jens Axboe wrote: > > > > On Fri, Feb 25 2005, Linus Torvalds wrote: > > > > > > > > > > > > > >

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Mark Haverkamp
On Mon, 2005-02-28 at 16:51 +0100, Jens Axboe wrote: > On Mon, Feb 28 2005, Mark Haverkamp wrote: > > On Sat, 2005-02-26 at 13:39 +0100, Jens Axboe wrote: > > > On Fri, Feb 25 2005, Linus Torvalds wrote: > > > > > > > > > > > > On Fri, 25 Feb 2005, Andrew Morton wrote: > > > > > > > > > > It see

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Jens Axboe
On Mon, Feb 28 2005, Mark Haverkamp wrote: > On Sat, 2005-02-26 at 13:39 +0100, Jens Axboe wrote: > > On Fri, Feb 25 2005, Linus Torvalds wrote: > > > > > > > > > On Fri, 25 Feb 2005, Andrew Morton wrote: > > > > > > > > It seems very weird for dm to be shoving NULL page*'s into the middle > >

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Mark Haverkamp
On Mon, 2005-02-28 at 07:32 -0800, Mark Haverkamp wrote: > On Sat, 2005-02-26 at 13:39 +0100, Jens Axboe wrote: > > On Fri, Feb 25 2005, Linus Torvalds wrote: > > > > > > > > > On Fri, 25 Feb 2005, Andrew Morton wrote: > > > > > > > > It seems very weird for dm to be shoving NULL page*'s into th

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-28 Thread Mark Haverkamp
On Sat, 2005-02-26 at 13:39 +0100, Jens Axboe wrote: > On Fri, Feb 25 2005, Linus Torvalds wrote: > > > > > > On Fri, 25 Feb 2005, Andrew Morton wrote: > > > > > > It seems very weird for dm to be shoving NULL page*'s into the middle of a > > > bio's bvec array, so your fix might end up being a

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-26 Thread Jens Axboe
On Fri, Feb 25 2005, Linus Torvalds wrote: > > > On Fri, 25 Feb 2005, Andrew Morton wrote: > > > > It seems very weird for dm to be shoving NULL page*'s into the middle of a > > bio's bvec array, so your fix might end up being a workaround pending a > > closer look at what's going on in there. >

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-25 Thread Linus Torvalds
On Fri, 25 Feb 2005, Andrew Morton wrote: > > It seems very weird for dm to be shoving NULL page*'s into the middle of a > bio's bvec array, so your fix might end up being a workaround pending a > closer look at what's going on in there. Yes. I don't see how this patch can be anything but banda

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-25 Thread Andrew Morton
Mark Haverkamp <[EMAIL PROTECTED]> wrote: > > > Last September a fix was checked in for a memory leak problem in > bounce_end_io causing the entire bio to be checked. This ended up > causing some dm cloned bios that had bounce buffers to free NULL pages > because their bi_idx can be non-zero. T

Re: [PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-25 Thread Mark Haverkamp
On Fri, 2005-02-25 at 09:03 -0800, Mark Haverkamp wrote: > Last September a fix was checked in for a memory leak problem in > bounce_end_io causing the entire bio to be checked. This ended up > causing some dm cloned bios that had bounce buffers to free NULL pages > because their bi_idx can be non

[PATCH] Fix panic in 2.6 with bounced bio and dm

2005-02-25 Thread Mark Haverkamp
Last September a fix was checked in for a memory leak problem in bounce_end_io causing the entire bio to be checked. This ended up causing some dm cloned bios that had bounce buffers to free NULL pages because their bi_idx can be non-zero. This patch skips NULL pages in the bio's bio_vec. I'm