Re: [PATCH] Fix rmmod/read/write races in /proc entries

2007-01-24 Thread Alexey Dobriyan
goto out_dec; > > + > > You'll be shocked to know that I'd prefer more comments in there. Enough > for a later maintainer to be able to understand what's going on. Here is replacement patch with rewritten changelog and comments in place. HTH. [PATCH] Fix

Re: [PATCH] Fix rmmod/read/write races in /proc entries

2007-01-23 Thread Andrew Morton
On Mon, 15 Jan 2007 18:39:27 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > pde = create_proc_entry() > if (!pde) > return -ENOMEM; > pde->write_proc = ...; > open > wri

[PATCH] Fix rmmod/read/write races in /proc entries

2007-01-15 Thread Alexey Dobriyan
pde = create_proc_entry() if (!pde) return -ENOMEM; pde->write_proc = ...; open write copy_from_user pde = create_proc_entry(); if (!pde)