Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Adrian Bunk
On Mon, Jun 04, 2007 at 02:13:11PM +0200, Rolf Eike Beer wrote: > Adrian Bunk wrote: > > On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote: > > > Fix roundup_pow_of_two(1) > > > > > > 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It > > > does in case the

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Jiri Kosina
On Mon, 4 Jun 2007, Adrian Bunk wrote: > > 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It > > does > > in case the argument is a variable but in case it's a constant it behaves > > wrong and returns 0. Probably nobody ever did it so this was never noticed. > I'm not

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Rolf Eike Beer
Adrian Bunk wrote: > On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote: > > Fix roundup_pow_of_two(1) > > > > 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It > > does in case the argument is a variable but in case it's a constant it > > behaves wrong and

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Adrian Bunk
On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote: > Fix roundup_pow_of_two(1) > > 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does > in case the argument is a variable but in case it's a constant it behaves > wrong and returns 0. Probably nobody ever did

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Adrian Bunk
On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote: Fix roundup_pow_of_two(1) 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does in case the argument is a variable but in case it's a constant it behaves wrong and returns 0. Probably nobody ever did it

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Rolf Eike Beer
Adrian Bunk wrote: On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote: Fix roundup_pow_of_two(1) 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does in case the argument is a variable but in case it's a constant it behaves wrong and returns 0.

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Jiri Kosina
On Mon, 4 Jun 2007, Adrian Bunk wrote: 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does in case the argument is a variable but in case it's a constant it behaves wrong and returns 0. Probably nobody ever did it so this was never noticed. I'm not getting the

Re: [PATCH] Fix roundup_pow_of_two(1)

2007-06-04 Thread Adrian Bunk
On Mon, Jun 04, 2007 at 02:13:11PM +0200, Rolf Eike Beer wrote: Adrian Bunk wrote: On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote: Fix roundup_pow_of_two(1) 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does in case the argument is a

[PATCH] Fix roundup_pow_of_two(1)

2007-05-18 Thread Rolf Eike Beer
Fix roundup_pow_of_two(1) 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does in case the argument is a variable but in case it's a constant it behaves wrong and returns 0. Probably nobody ever did it so this was never noticed. Signed-off-by: Rolf Eike Beer <[EMAIL

[PATCH] Fix roundup_pow_of_two(1)

2007-05-18 Thread Rolf Eike Beer
Fix roundup_pow_of_two(1) 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does in case the argument is a variable but in case it's a constant it behaves wrong and returns 0. Probably nobody ever did it so this was never noticed. Signed-off-by: Rolf Eike Beer [EMAIL