Re: [PATCH] Fix the x86 specializations of atomic_[set|clear]_mask

2014-10-16 Thread Patrick Palka
On Thu, Oct 16, 2014 at 4:24 PM, Peter Zijlstra wrote: > On Thu, Oct 16, 2014 at 12:49:43PM -0400, Patrick Palka wrote: >> On Oct 16, 2014 4:02 AM, "Peter Zijlstra" wrote: >> > >> > On Wed, Oct 15, 2014 at 04:38:01PM -0400, Patrick Palka wrote: >> > > This patch fixes a number of issues with thes

Re: [PATCH] Fix the x86 specializations of atomic_[set|clear]_mask

2014-10-16 Thread Peter Zijlstra
On Thu, Oct 16, 2014 at 12:49:43PM -0400, Patrick Palka wrote: > On Oct 16, 2014 4:02 AM, "Peter Zijlstra" wrote: > > > > On Wed, Oct 15, 2014 at 04:38:01PM -0400, Patrick Palka wrote: > > > This patch fixes a number of issues with these specializations: > > > > > > 1. The memory operand inside

Re: [PATCH] Fix the x86 specializations of atomic_[set|clear]_mask

2014-10-16 Thread Peter Zijlstra
On Wed, Oct 15, 2014 at 04:38:01PM -0400, Patrick Palka wrote: > This patch fixes a number of issues with these specializations: > > 1. The memory operand inside the asm specification is erroneously > declared read-only instead of read-write. > > 2. There is no reason to require the 1st ope

[PATCH] Fix the x86 specializations of atomic_[set|clear]_mask

2014-10-15 Thread Patrick Palka
This patch fixes a number of issues with these specializations: 1. The memory operand inside the asm specification is erroneously declared read-only instead of read-write. 2. There is no reason to require the 1st operand of andl/orl to be inside a register; the 1st operand could also be a