Re: [PATCH] GBPAGES: Fix global bit for 64bit

2008-01-31 Thread Andi Kleen
> Last time when my patch to do this was in the tree, it caused random > things to fail, even after increasing the strength of various tlb > flushes. Did you change something to fix this? At least all the flushes in init_64 are global now. But my latest iteration of gbpages actually doesn't n

Re: [PATCH] GBPAGES: Fix global bit for 64bit

2008-01-31 Thread Jeremy Fitzhardinge
Andi Kleen wrote: [Ideally apply before the patch to enable gbpages direct mapping] The gbpages direct patch assumed that __PAGE_KERNEL contains _PAGE_GLOBAL (I think because that was true at some point in git-x86 and i forgot to remove it again when forward porting) This is currently true on

[PATCH] GBPAGES: Fix global bit for 64bit

2008-01-31 Thread Andi Kleen
[Ideally apply before the patch to enable gbpages direct mapping] The gbpages direct patch assumed that __PAGE_KERNEL contains _PAGE_GLOBAL (I think because that was true at some point in git-x86 and i forgot to remove it again when forward porting) This is currently true on 32bit, but not on 6