Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-10-05 Thread Bernardo Innocenti
On 10/05/2007 09:15 AM, Pavel Machek wrote: This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional "state" parameter ranging from 0 (running) to 3 (poweroff). No, please don't. Having int with 0/3 being valid specifying what to do is evil.

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-10-05 Thread Pavel Machek
Hi! > This patch merges the fb_powerup and fb_powerdown hooks in a single > operation fb_power with an additional "state" parameter ranging > from 0 (running) to 3 (poweroff). No, please don't. Having int with 0/3 being valid specifying what to do is evil. enum is less evil, but what's wrong

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-10-05 Thread Pavel Machek
Hi! This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional state parameter ranging from 0 (running) to 3 (poweroff). No, please don't. Having int with 0/3 being valid specifying what to do is evil. enum is less evil, but what's wrong about

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-10-05 Thread Bernardo Innocenti
On 10/05/2007 09:15 AM, Pavel Machek wrote: This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional state parameter ranging from 0 (running) to 3 (poweroff). No, please don't. Having int with 0/3 being valid specifying what to do is evil.

[PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-23 Thread Bernardo Innocenti
This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional "state" parameter ranging from 0 (running) to 3 (poweroff). The geodefb uses state 2 as an intermediate low-power mode, where the LX or GX video unit is turned off, but the GPU may still be

[PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-09-23 Thread Bernardo Innocenti
This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional "state" parameter ranging from 0 (running) to 3 (poweroff). The geodefb uses state 2 as an intermediate low-power mode, where the LX or GX video unit is turned off, but the GPU may still be

[PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-09-23 Thread Bernardo Innocenti
This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional state parameter ranging from 0 (running) to 3 (poweroff). The geodefb uses state 2 as an intermediate low-power mode, where the LX or GX video unit is turned off, but the GPU may still be

[PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-23 Thread Bernardo Innocenti
This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional state parameter ranging from 0 (running) to 3 (poweroff). The geodefb uses state 2 as an intermediate low-power mode, where the LX or GX video unit is turned off, but the GPU may still be