Re: [PATCH] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-30 Thread Linus Walleij
On Tue, Sep 25, 2012 at 2:03 PM, Neil Zhang wrote: > We need to return 0 or 1 when get gpio value. OK... > static int pxa_gpio_get(struct gpio_chip *chip, unsigned offset) > { > - return readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET) & (1 << > offset); > + u32 gplr = __raw_rea

[PATCH] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-25 Thread Neil Zhang
We need to return 0 or 1 when get gpio value. Signed-off-by: Neil Zhang --- drivers/gpio/gpio-pxa.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 9cac88a..1f9a058 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/dri