Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error,

2016-07-06 Thread Dmitry Torokhov
On Tue, Jul 05, 2016 at 10:01:11AM -0700, Bjorn Andersson wrote: > On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote: > > Your subject line should be a short and descriptive summary, followed by > an empty line and then potentially a longer description motivating your > patch. Please read section

Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error,

2016-07-06 Thread Dmitry Torokhov
On Tue, Jul 05, 2016 at 10:01:11AM -0700, Bjorn Andersson wrote: > On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote: > > Your subject line should be a short and descriptive summary, followed by > an empty line and then potentially a longer description motivating your > patch. Please read section

Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error,

2016-07-06 Thread arvind Yadav
Sorry for subject. Thanks for reviewing my patch. I will take care and follow the standard now. regards, Arvind On Tuesday 05 July 2016 10:31 PM, Bjorn Andersson wrote: On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote: Your subject line should be a short and descriptive summary, followed by

Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error,

2016-07-06 Thread arvind Yadav
Sorry for subject. Thanks for reviewing my patch. I will take care and follow the standard now. regards, Arvind On Tuesday 05 July 2016 10:31 PM, Bjorn Andersson wrote: On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote: Your subject line should be a short and descriptive summary, followed by

Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error,

2016-07-05 Thread Bjorn Andersson
On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote: Your subject line should be a short and descriptive summary, followed by an empty line and then potentially a longer description motivating your patch. Please read section #14 of Documentation/SubmittingPatches. > Signed-off-by: Arvind Yadav

Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error,

2016-07-05 Thread Bjorn Andersson
On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote: Your subject line should be a short and descriptive summary, followed by an empty line and then potentially a longer description motivating your patch. Please read section #14 of Documentation/SubmittingPatches. > Signed-off-by: Arvind Yadav >

[PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error, sin

2016-07-05 Thread Arvind Yadav
Signed-off-by: Arvind Yadav --- drivers/input/keyboard/gpio_keys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 2909365..a2fa3bb 100644 ---

[PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error, sin

2016-07-05 Thread Arvind Yadav
Signed-off-by: Arvind Yadav --- drivers/input/keyboard/gpio_keys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 2909365..a2fa3bb 100644 --- a/drivers/input/keyboard/gpio_keys.c +++