Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
On Fri, Nov 11, 2016 at 01:58:46PM +, Emil Velikov wrote: > On 11 November 2016 at 10:56, Liviu Dudau wrote: > > Hi Shailendra, > > > > On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: > >> From: "Shailendra Verma" > >> > >>

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
On Fri, Nov 11, 2016 at 01:58:46PM +, Emil Velikov wrote: > On 11 November 2016 at 10:56, Liviu Dudau wrote: > > Hi Shailendra, > > > > On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: > >> From: "Shailendra Verma" > >> > >> There is possible dereference of NULL pointer if

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Emil Velikov
On 11 November 2016 at 10:56, Liviu Dudau wrote: > Hi Shailendra, > > On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: >> From: "Shailendra Verma" >> >> There is possible dereference of NULL pointer if kmalloc fails. > > You could

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Emil Velikov
On 11 November 2016 at 10:56, Liviu Dudau wrote: > Hi Shailendra, > > On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: >> From: "Shailendra Verma" >> >> There is possible dereference of NULL pointer if kmalloc fails. > > You could add: ... when the function returns. From the

[PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Shailendra Verma
From: "Shailendra Verma" There is possible dereference of NULL pointer if kmalloc fails, When function returns.So return NULL if kmalloc fails. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/arm/malidp_planes.c |3 +++ 1 file

[PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Shailendra Verma
From: "Shailendra Verma" There is possible dereference of NULL pointer if kmalloc fails, When function returns.So return NULL if kmalloc fails. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/arm/malidp_planes.c |3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
Hi Shailendra, On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: > From: "Shailendra Verma" > > There is possible dereference of NULL pointer if kmalloc fails. You could add: ... when the function returns. From the patch itself it is not clear where

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
Hi Shailendra, On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: > From: "Shailendra Verma" > > There is possible dereference of NULL pointer if kmalloc fails. You could add: ... when the function returns. From the patch itself it is not clear where the problem is. > So return

[PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Shailendra Verma
From: "Shailendra Verma" There is possible dereference of NULL pointer if kmalloc fails. So return NULL if kmalloc fails. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/arm/malidp_planes.c |3 +++ 1 file changed, 3 insertions(+)

[PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Shailendra Verma
From: "Shailendra Verma" There is possible dereference of NULL pointer if kmalloc fails. So return NULL if kmalloc fails. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/arm/malidp_planes.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_planes.c