Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, 21 Mar 2017, Jiri Kosina wrote: > Sorry, I messed up. I exchanged this patch with another one that fixed > report descriptor (which we can't yet, although I have been thinking about > ways how to do this properly). FTR, this is now also dropped from hid.git. Thanks again for catching

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, 21 Mar 2017, Jiri Kosina wrote: > Sorry, I messed up. I exchanged this patch with another one that fixed > report descriptor (which we can't yet, although I have been thinking about > ways how to do this properly). FTR, this is now also dropped from hid.git. Thanks again for catching

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, Mar 21, 2017 at 7:04 AM, Jiri Kosina wrote: > > On Tue, 14 Feb 2017, Martyn Welch wrote: > > > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > > in it's capabilities, which is what user space expects a touchscreen > > device to report. This is

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, Mar 21, 2017 at 7:04 AM, Jiri Kosina wrote: > > On Tue, 14 Feb 2017, Martyn Welch wrote: > > > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > > in it's capabilities, which is what user space expects a touchscreen > > device to report. This is causing udev to

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, 21 Mar 2017, Dmitry Torokhov wrote: > > > This patch adds a special driver for the device to correct the > > > capabilities reported. > > > > Applied to for-4.12/accutouch. Thanks, > > Hmm, can't we fix usage code from udev, like we do with other keymaps? Sorry, I messed up. I exchanged

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, 21 Mar 2017, Dmitry Torokhov wrote: > > > This patch adds a special driver for the device to correct the > > > capabilities reported. > > > > Applied to for-4.12/accutouch. Thanks, > > Hmm, can't we fix usage code from udev, like we do with other keymaps? Sorry, I messed up. I exchanged

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, 14 Feb 2017, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is what user space expects a touchscreen > device to report. This is causing udev to consider the device to be a > "VMware's USB mouse" rather than as

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Tue, 14 Feb 2017, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is what user space expects a touchscreen > device to report. This is causing udev to consider the device to be a > "VMware's USB mouse" rather than as

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Wed, Mar 01, 2017 at 02:30:31PM +0100, Benjamin Tissoires wrote: > Hi, > > On Feb 28 2017 or thereabouts, Martyn Welch wrote: > > This patch has been sitting on the list for about 2 weeks. Is there > > anything wrong with this patch? > > The only wrong thing with the patch (I haven't started

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Wed, Mar 01, 2017 at 02:30:31PM +0100, Benjamin Tissoires wrote: > Hi, > > On Feb 28 2017 or thereabouts, Martyn Welch wrote: > > This patch has been sitting on the list for about 2 weeks. Is there > > anything wrong with this patch? > > The only wrong thing with the patch (I haven't started

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Feb 14 2017 or thereabouts, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is what user space expects a touchscreen > device to report. This is causing udev to consider the device to be a > "VMware's USB mouse" rather

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

On Feb 14 2017 or thereabouts, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is what user space expects a touchscreen > device to report. This is causing udev to consider the device to be a > "VMware's USB mouse" rather

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

Hi, On Feb 28 2017 or thereabouts, Martyn Welch wrote: > This patch has been sitting on the list for about 2 weeks. Is there > anything wrong with this patch? The only wrong thing with the patch (I haven't started reviewing it yet) is the timing. It was sent shortly before or at the time of the

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

Hi, On Feb 28 2017 or thereabouts, Martyn Welch wrote: > This patch has been sitting on the list for about 2 weeks. Is there > anything wrong with this patch? The only wrong thing with the patch (I haven't started reviewing it yet) is the timing. It was sent shortly before or at the time of the

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

This patch has been sitting on the list for about 2 weeks. Is there anything wrong with this patch? Thanks, Martyn On Tue, Feb 14, 2017 at 02:17:56PM +, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is what user

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

This patch has been sitting on the list for about 2 weeks. Is there anything wrong with this patch? Thanks, Martyn On Tue, Feb 14, 2017 at 02:17:56PM +, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is what user

[PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH in it's capabilities, which is what user space expects a touchscreen device to report. This is causing udev to consider the device to be a "VMware's USB mouse" rather than as a touchscreen, which results in a mouse cursor

[PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH in it's capabilities, which is what user space expects a touchscreen device to report. This is causing udev to consider the device to be a "VMware's USB mouse" rather than as a touchscreen, which results in a mouse cursor