Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-20 Thread Kai-Heng Feng
> On Jan 17, 2019, at 20:35, Benjamin Tissoires > wrote: > > On Thu, Jan 17, 2019 at 12:41 PM Kai-Heng Feng > wrote: >> >> >> >>> On Jan 17, 2019, at 16:06, Benjamin Tissoires >>> wrote: >>> >>> On Thu, Jan 17, 2019 at 6:02 AM Kai-Heng Feng >>> wrote: >> [snipped] Goodix says

Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-17 Thread Benjamin Tissoires
On Thu, Jan 17, 2019 at 12:41 PM Kai-Heng Feng wrote: > > > > > On Jan 17, 2019, at 16:06, Benjamin Tissoires > > wrote: > > > > On Thu, Jan 17, 2019 at 6:02 AM Kai-Heng Feng > > wrote: > [snipped] > >> Goodix says the firmware needs at least 60ms to fully respond ON and > >> SLEEP command. >

Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-17 Thread Kai-Heng Feng
> On Jan 17, 2019, at 16:06, Benjamin Tissoires > wrote: > > On Thu, Jan 17, 2019 at 6:02 AM Kai-Heng Feng > wrote: [snipped] >> Goodix says the firmware needs at least 60ms to fully respond ON and >> SLEEP command. > > I was about to say that this is not conformant to the specification. >

Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-17 Thread Benjamin Tissoires
On Thu, Jan 17, 2019 at 6:02 AM Kai-Heng Feng wrote: > > > > > On Jan 16, 2019, at 16:21, Kai Heng Feng > > wrote: > > > > > > > >> On Jan 14, 2019, at 19:18, Jiri Kosina wrote: > >> > >> On Mon, 14 Jan 2019, Kai-Heng Feng wrote: > >> > >>> A Goodix touchpad doesn't work. Touching the touchpad

Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-16 Thread Kai-Heng Feng
> On Jan 16, 2019, at 16:21, Kai Heng Feng wrote: > > > >> On Jan 14, 2019, at 19:18, Jiri Kosina wrote: >> >> On Mon, 14 Jan 2019, Kai-Heng Feng wrote: >> >>> A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ >>> but there's no input event from HID subsystem. >>>

Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-16 Thread Kai Heng Feng
> On Jan 14, 2019, at 19:18, Jiri Kosina wrote: > > On Mon, 14 Jan 2019, Kai-Heng Feng wrote: > >> A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ >> but there's no input event from HID subsystem. >> >> Turns out it reports some invalid data: >> [ 22.136630] i2c_hid

Re: [PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-14 Thread Jiri Kosina
On Mon, 14 Jan 2019, Kai-Heng Feng wrote: > A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ > but there's no input event from HID subsystem. > > Turns out it reports some invalid data: > [ 22.136630] i2c_hid i2c-DELL091F:00: input: 0b 00 01 00 00 00 00 00 00 00 > 00 > >

[PATCH] HID: i2c-hid: Disable runtime PM on Goodix touchpad

2019-01-14 Thread Kai-Heng Feng
A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ but there's no input event from HID subsystem. Turns out it reports some invalid data: [ 22.136630] i2c_hid i2c-DELL091F:00: input: 0b 00 01 00 00 00 00 00 00 00 00 After some trial and error, it's another device that