Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-28 Thread Rushikesh S Kadam
Hi Nick Thanks once again for your time. I've addressed majority of the comments below. Will send a v2 shortly. Please see my replies inline below. On Tue, Mar 26, 2019 at 06:39:14PM -0600, Nick Crews wrote: > Hi Rushikesh, I know I've been reviewing this on Chromium, but I have > some more

Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-27 Thread Nick Crews
On Tue, Mar 26, 2019 at 8:22 PM Srinivas Pandruvada wrote: > > On Tue, 2019-03-26 at 18:39 -0600, Nick Crews wrote: > > Hi Rushikesh, I know I've been reviewing this on Chromium, but I have > > some more larges-scale design thoughts. > Hi Nick. > > Does this fundamentally change, the way it is

Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-26 Thread Srinivas Pandruvada
On Tue, 2019-03-26 at 18:39 -0600, Nick Crews wrote: > Hi Rushikesh, I know I've been reviewing this on Chromium, but I have > some more larges-scale design thoughts. Hi Nick. Does this fundamentally change, the way it is done here or can wait for subsequent revisions later? Thanks, Srinivas >

Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-26 Thread Nick Crews
Hi Rushikesh, I know I've been reviewing this on Chromium, but I have some more larges-scale design thoughts. > > diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c > > b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c > > new file mode 100644 > > index 000..85d71d3 > > --- /dev/null > >

Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-26 Thread Jett Rink
Tested-by: Jett Rink On Sun, Mar 24, 2019 at 9:36 AM Srinivas Pandruvada wrote: > > On Sat, 2019-03-23 at 16:46 +0530, Rushikesh S Kadam wrote: > > This driver adds support for loading Intel Integrated > > Sensor Hub (ISH) firmware from host file system to ISH > > SRAM and start execution. > >

Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-24 Thread Srinivas Pandruvada
On Sat, 2019-03-23 at 16:46 +0530, Rushikesh S Kadam wrote: > This driver adds support for loading Intel Integrated > Sensor Hub (ISH) firmware from host file system to ISH > SRAM and start execution. > > At power-on, the ISH subsystem shall boot to an interim > Shim loader-firmware, which shall

[PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-23 Thread Rushikesh S Kadam
This driver adds support for loading Intel Integrated Sensor Hub (ISH) firmware from host file system to ISH SRAM and start execution. At power-on, the ISH subsystem shall boot to an interim Shim loader-firmware, which shall expose an ISHTP loader device. The driver implements an ISHTP client