Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-19 Thread Jiri Kosina
On Wed, 18 Oct 2017, Hendrik Langer wrote: > Tested-by: Hendrik Langer > > Confirmed, the patch fixes the probem for me. > All freezes/Oops and rmi or input related error messages are gone. Even > keyboard and touchpad are working now! Thanks a lot for confirmation. Now

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-19 Thread Jiri Kosina
On Wed, 18 Oct 2017, Hendrik Langer wrote: > Tested-by: Hendrik Langer > > Confirmed, the patch fixes the probem for me. > All freezes/Oops and rmi or input related error messages are gone. Even > keyboard and touchpad are working now! Thanks a lot for confirmation. Now queued in

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Benjamin Tissoires
On Oct 18 2017 or thereabouts, Andrew Duggan wrote: > > > On 10/18/2017 07:13 AM, Jiri Kosina wrote: > > On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > > > > > > The hid-rmi driver may handle non rmi devices on composite USB devices. > > > > Callbacks need to make sure that the current device

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Benjamin Tissoires
On Oct 18 2017 or thereabouts, Andrew Duggan wrote: > > > On 10/18/2017 07:13 AM, Jiri Kosina wrote: > > On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > > > > > > The hid-rmi driver may handle non rmi devices on composite USB devices. > > > > Callbacks need to make sure that the current device

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Hendrik Langer
On 18/10/17 16:13, Jiri Kosina wrote: > On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > >>> The hid-rmi driver may handle non rmi devices on composite USB devices. >>> Callbacks need to make sure that the current device is a RMI device before >>> calling RMI specific functions. Most callbacks

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Hendrik Langer
On 18/10/17 16:13, Jiri Kosina wrote: > On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > >>> The hid-rmi driver may handle non rmi devices on composite USB devices. >>> Callbacks need to make sure that the current device is a RMI device before >>> calling RMI specific functions. Most callbacks

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Andrew Duggan
On 10/18/2017 07:13 AM, Jiri Kosina wrote: On Wed, 18 Oct 2017, Benjamin Tissoires wrote: The hid-rmi driver may handle non rmi devices on composite USB devices. Callbacks need to make sure that the current device is a RMI device before calling RMI specific functions. Most callbacks already

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Andrew Duggan
On 10/18/2017 07:13 AM, Jiri Kosina wrote: On Wed, 18 Oct 2017, Benjamin Tissoires wrote: The hid-rmi driver may handle non rmi devices on composite USB devices. Callbacks need to make sure that the current device is a RMI device before calling RMI specific functions. Most callbacks already

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Jiri Kosina
On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > > The hid-rmi driver may handle non rmi devices on composite USB devices. > > Callbacks need to make sure that the current device is a RMI device before > > calling RMI specific functions. Most callbacks already have this check, but > > this patch

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Jiri Kosina
On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > > The hid-rmi driver may handle non rmi devices on composite USB devices. > > Callbacks need to make sure that the current device is a RMI device before > > calling RMI specific functions. Most callbacks already have this check, but > > this patch

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Benjamin Tissoires
On Oct 17 2017 or thereabouts, Andrew Duggan wrote: > The hid-rmi driver may handle non rmi devices on composite USB devices. > Callbacks need to make sure that the current device is a RMI device before > calling RMI specific functions. Most callbacks already have this check, but > this patch adds

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-18 Thread Benjamin Tissoires
On Oct 17 2017 or thereabouts, Andrew Duggan wrote: > The hid-rmi driver may handle non rmi devices on composite USB devices. > Callbacks need to make sure that the current device is a RMI device before > calling RMI specific functions. Most callbacks already have this check, but > this patch adds

[PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-17 Thread Andrew Duggan
The hid-rmi driver may handle non rmi devices on composite USB devices. Callbacks need to make sure that the current device is a RMI device before calling RMI specific functions. Most callbacks already have this check, but this patch adds checks to the remaining callbacks. Signed-off-by: Andrew

[PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

2017-10-17 Thread Andrew Duggan
The hid-rmi driver may handle non rmi devices on composite USB devices. Callbacks need to make sure that the current device is a RMI device before calling RMI specific functions. Most callbacks already have this check, but this patch adds checks to the remaining callbacks. Signed-off-by: Andrew