Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-25 Thread Mikko Perttunen
On 07/25/16 18:23, Mikko Perttunen wrote: On 07/25/16 14:05, Antonio Ospite wrote: You can also find out the length of the raw output report with trial and error, start with a line like this: $ sudo hexdump -v -e '49/1 "%02x " "\n"' /dev/hidraw0 and increase/decrease the value (49 works with o

Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-25 Thread Mikko Perttunen
On 07/25/16 14:05, Antonio Ospite wrote: On Mon, 25 Jul 2016 11:14:04 +0200 Benjamin Tissoires wrote: On Jul 21 2016 or thereabouts, Antonio Ospite wrote: [...] It would be interesting to understand why some (supposedly) compatible devices break, maybe they rely on the fact that the PS3 woul

Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-25 Thread Antonio Ospite
On Mon, 25 Jul 2016 11:14:04 +0200 Benjamin Tissoires wrote: > On Jul 21 2016 or thereabouts, Antonio Ospite wrote: [...] > > It would be interesting to understand why some (supposedly) compatible > > devices break, maybe they rely on the fact that the PS3 would use the > > original report? > >

Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-25 Thread Benjamin Tissoires
On Jul 21 2016 or thereabouts, Antonio Ospite wrote: > On Tue, 19 Jul 2016 09:08:27 +0300 > Mikko Perttunen wrote: > > > On 07/18/16 17:28, Benjamin Tissoires wrote: > [...] > > > > > > Also, I think it would be better to have a check on the existing report > > > descriptor instead of blindly fix

Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-21 Thread Antonio Ospite
On Tue, 19 Jul 2016 09:08:27 +0300 Mikko Perttunen wrote: > On 07/18/16 17:28, Benjamin Tissoires wrote: [...] > > > > Also, I think it would be better to have a check on the existing report > > descriptor instead of blindly fixing it. Other drivers make sure they > > are fixing the correct regio

Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-18 Thread Mikko Perttunen
On 07/18/16 17:28, Benjamin Tissoires wrote: On Jul 17 2016 or thereabouts, Mikko Perttunen wrote: From: Mikko Perttunen ... #include #include #include +#include + +#include "usbhid/usbhid.h" I spent a lot of effort 2 years ago to remove the usb dependency, I'd prefer not adding a stro

Re: [PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-18 Thread Benjamin Tissoires
On Jul 17 2016 or thereabouts, Mikko Perttunen wrote: > From: Mikko Perttunen > > The FutureMax Dance Mat claims to be a SixAxis controller > but breaks if descriptor fixups are applied. Detect the > device using its USB product string and disable fixups > when it is detected. > > Signed-off-by:

[PATCH] HID: sony: disable descriptor fixup for FutureMax Dance Mat

2016-07-17 Thread Mikko Perttunen
From: Mikko Perttunen The FutureMax Dance Mat claims to be a SixAxis controller but breaks if descriptor fixups are applied. Detect the device using its USB product string and disable fixups when it is detected. Signed-off-by: Mikko Perttunen --- drivers/hid/hid-sony.c | 15 ++- 1