Re: [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map

2014-11-16 Thread Pavel Machek
On Fri 2014-11-14 23:44:07, Sebastian Reichel wrote: > On Fri, Nov 14, 2014 at 02:06:37PM -0800, Dmitry Torokhov wrote: > > Return value of irq_of_parse_and_map() is unsigned int, with 0 > > indicating failure, so testing for negative result never works. > > > > Signed-off-by: Dmitry Torokhov >

Re: [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Sebastian Reichel
On Fri, Nov 14, 2014 at 02:06:37PM -0800, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/co

[PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. drivers/hsi/clients/nokia-modem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion