Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Richard B. Johnson
On Wed, 7 Feb 2001, [ISO-8859-1] Gérard Roudier wrote: > > You missed the newer statements about every piece of hardware being > assumed to be hot-pluggable and all the hardware being under full control > by CPU. > > You also missed the well known point that only device drivers are broken > und

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Gérard Roudier
You missed the newer statements about every piece of hardware being assumed to be hot-pluggable and all the hardware being under full control by CPU. You also missed the well known point that only device drivers are broken under Linux and that all the generic O/S code is just perfect. :-) Gér

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Alan Cox
> I stand by my statement. PCI devices that require resources are > required to provide read/write registers indicating these resources > whether or not the enable bits are set. This is mandatory. And the assignment of those resources is done by pci_enable_device. So looking at the irq data or t

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Richard B. Johnson
On Wed, 7 Feb 2001, Jeff Garzik wrote: > "Richard B. Johnson" wrote: > > A PCI device does not and should not be enabled to probe for resources! > > Some PCI devices do not -have- resources until pci_enable_device() is > called, hence the rule. > I stand by my statement. PCI devices that requi

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Jeff Garzik
"Richard B. Johnson" wrote: > A PCI device does not and should not be enabled to probe for resources! Some PCI devices do not -have- resources until pci_enable_device() is called, hence the rule. > It is only devices that have BIOS that require the device to be enabled > for memory I/O prior to

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Richard B. Johnson
On Wed, 7 Feb 2001 [EMAIL PROTECTED] wrote: > > Hi Alan, > > Another driver not doing pci_enable_device() early enough. > > Dave. > A PCI device does not and should not be enabled to probe for resources! It is only devices that have BIOS that require the device to be enabled for memory I/O

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread davej
Jeff Garzik wrote.. > rejected -- 'irq' assigned a value before pci_enable_device called. > better patch installed locally. Ugh, yep missed that one. Will look more carefully for those assignments. Dave. -- | Dave Jones.http://www.suse.de/~davej | SuSE Labs - To unsubscribe from thi

Re: [PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread Jeff Garzik
Applied locally: pci_device_enable() cleanups for hamachi, eepro100, starfire I'll have to look at ne2k-pci, I think a patch in -ac may be spurious. Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns

[PATCH] Hamachi not doing pci_enable before reading resources

2001-02-07 Thread davej
Hi Alan, Another driver not doing pci_enable_device() early enough. Dave. -- | Dave Jones.http://www.suse.de/~davej | SuSE Labs diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/hamachi.c linux-dj/drivers/net/hamachi.c --- linux/drivers/net/hamachi.c Wed Feb 7 12:42: