Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-14 Thread Andreas Werner
On Thu, Nov 14, 2013 at 05:39:52AM -0800, Joe Perches wrote: > On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote: > > > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > > > > > > That is because if you look at the only caller of this function, > > > > > > which is

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-14 Thread Joe Perches
On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote: > > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > > > > > That is because if you look at the only caller of this function, > > > > > which is pch_i2c_wait_for_check_xfer(), you will see that at the > > > > > only place where

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-14 Thread Joe Perches
On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote: On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: That is because if you look at the only caller of this function, which is pch_i2c_wait_for_check_xfer(), you will see that at the only place where pch_i2c_getack() is

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-14 Thread Andreas Werner
On Thu, Nov 14, 2013 at 05:39:52AM -0800, Joe Perches wrote: On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote: On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: That is because if you look at the only caller of this function, which is pch_i2c_wait_for_check_xfer(),

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-13 Thread Marek Vasut
Dear Andreas Werner, > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > > Dear Andreas Werner, > > > > > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > > > Dear Andreas Werner, > > > > > > > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, >

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-13 Thread Andreas Werner
On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > Dear Andreas Werner, > > > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > > Dear Andreas Werner, > > > > > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > > > > the driver will print a lot

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-13 Thread Andreas Werner
On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: Dear Andreas Werner, On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: Dear Andreas Werner, Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will print a lot of error messages

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-13 Thread Marek Vasut
Dear Andreas Werner, On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: Dear Andreas Werner, On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: Dear Andreas Werner, Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
Dear Andreas Werner, > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > Dear Andreas Werner, > > > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > > > the driver will print a lot of error messages if there was no ACK > > > received. > > > > > > i2cdetect

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Andreas Werner
On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > Dear Andreas Werner, > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > > the driver will print a lot of error messages if there was no ACK > > received. > > > > i2cdetect normally print a table with all the

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
Dear Andreas Werner, > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > the driver will print a lot of error messages if there was no ACK > received. > > i2cdetect normally print a table with all the available devices. If there > is no device on the address, the table will be

[PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Andreas Werner
Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will print a lot of error messages if there was no ACK received. i2cdetect normally print a table with all the available devices. If there is no device on the address, the table will be empty. Currently with the

[PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Andreas Werner
Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will print a lot of error messages if there was no ACK received. i2cdetect normally print a table with all the available devices. If there is no device on the address, the table will be empty. Currently with the

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
Dear Andreas Werner, Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will print a lot of error messages if there was no ACK received. i2cdetect normally print a table with all the available devices. If there is no device on the address, the table will be

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Andreas Werner
On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: Dear Andreas Werner, Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will print a lot of error messages if there was no ACK received. i2cdetect normally print a table with all the available

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
Dear Andreas Werner, On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: Dear Andreas Werner, Using the i2c-eg20t driver and call i2cdetect or probe on the bus, the driver will print a lot of error messages if there was no ACK received. i2cdetect normally print a