Re: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file

2005-03-31 Thread Corey Minyard
Ok, I have taken some time from suffering (packaging perl modules) to get back to this. Here's a new patch with the debug calls removed, as you requested. Thanks, -Corey Jean Delvare wrote: Hi Corey, Call i2c_transfer() from i2c_master_send() and i2c_master_recv() to avoid the redundant code t

Re: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file

2005-03-23 Thread Jean Delvare
Hi Corey, > Call i2c_transfer() from i2c_master_send() and i2c_master_recv() > to avoid the redundant code that was in all three functions. I like this. You're right, there is code duplication here, which we can get rid of, so let's do so. I'd only have one comments about your patch: You can get

[PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file

2005-03-23 Thread Corey Minyard
This is a series of patches to add a non-blocking interface to the I2C driver. Hopefully it is broken into small enough functional changes. I'm not posting the whole series right now, just the first few. Call i2c_transfer() from i2c_master_send() and i2c_master_recv() to avoid the redundant cod