Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Erez Shitrit
On Tue, Apr 25, 2017 at 2:14 PM, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit > wrote: >> On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: >>> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: From: Honggang Li Minimal hard_header_len set by bond_compu

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Or Gerlitz
On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit wrote: > On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: >> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >>> From: Honggang Li >>> >>> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which >>> is smaller than IPOIB_HARD_

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Erez Shitrit
On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >> From: Honggang Li >> >> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which >> is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the >> size of headroom t

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Honggang LI
On Tue, Apr 25, 2017 at 01:32:59PM +0300, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: > > From: Honggang Li > > > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the > > size

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Or Gerlitz
On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: > From: Honggang Li > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the > size of headroom to avoid skb_under_panic. sounds terrible, ipoib bonding is

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Yuval Shaia
On Tue, Apr 25, 2017 at 05:55:55PM +0800, Honggang LI wrote: > From: Honggang Li > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the > size of headroom to avoid skb_under_panic. > > [ 122.871493] ipoib_

[PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Honggang LI
From: Honggang Li Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the size of headroom to avoid skb_under_panic. [ 122.871493] ipoib_hard_header: skb->head= 8808179d9400, skb->data= 8808179d9420, skb