Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

2017-09-22 Thread Doug Ledford
On Wed, 2017-09-13 at 19:49 +0300, Leon Romanovsky wrote: > On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote: > > From: Colin Ian King > > > > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and > > add_status is OCRDMA_MBX_STATUS_FAILED err_num is

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

2017-09-22 Thread Doug Ledford
On Wed, 2017-09-13 at 19:49 +0300, Leon Romanovsky wrote: > On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote: > > From: Colin Ian King > > > > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and > > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN > >

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

2017-09-13 Thread Leon Romanovsky
On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote: > From: Colin Ian King > > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN > however the case OCRDMA_MBX_STATUS_FAILED is

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

2017-09-13 Thread Leon Romanovsky
On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote: > From: Colin Ian King > > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN > however the case OCRDMA_MBX_STATUS_FAILED is missing a break and > falls

[PATCH] IB/core: fix incorrect fall-through on switch statement

2017-09-11 Thread Colin King
From: Colin Ian King In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN however the case OCRDMA_MBX_STATUS_FAILED is missing a break and falls through to the default case which then re-assigns

[PATCH] IB/core: fix incorrect fall-through on switch statement

2017-09-11 Thread Colin King
From: Colin Ian King In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN however the case OCRDMA_MBX_STATUS_FAILED is missing a break and falls through to the default case which then re-assigns err_num to -EFAULT. Fix