Re: [PATCH] IB/lmx4: silence GCC warning

2013-02-13 Thread Bart Van Assche
On 10/29/12 10:50, Paul Bolle wrote: On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: You could use: u16 uninitialized_var(vlan); instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at

Re: [PATCH] IB/lmx4: silence GCC warning

2013-02-13 Thread Bart Van Assche
On 10/29/12 10:50, Paul Bolle wrote: On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: You could use: u16 uninitialized_var(vlan); instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at

Re: [PATCH] IB/lmx4: silence GCC warning

2012-10-29 Thread Paul Bolle
On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: > You could use: > >u16 uninitialized_var(vlan); > > instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at

Re: [PATCH] IB/lmx4: silence GCC warning

2012-10-29 Thread Paul Bolle
On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: You could use: u16 uninitialized_var(vlan); instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at https://lkml.org/lkml/2012/10/26/508

Re: [PATCH] IB/lmx4: silence GCC warning

2012-10-10 Thread Jack Morgenstein
You could use: u16 uninitialized_var(vlan); instead. Although this in the special QP data flow, I still prefer to avoid adding extra code (even setting initial values at procedure entry). The line above will also do the job. "uninitialized_var" is used elsewhere in the driver. See, for

Re: [PATCH] IB/lmx4: silence GCC warning

2012-10-10 Thread Jack Morgenstein
You could use: u16 uninitialized_var(vlan); instead. Although this in the special QP data flow, I still prefer to avoid adding extra code (even setting initial values at procedure entry). The line above will also do the job. uninitialized_var is used elsewhere in the driver. See, for

[PATCH] IB/lmx4: silence GCC warning

2012-09-28 Thread Paul Bolle
Building qp.o (part of the "Mellanox ConnectX HCA support" driver) triggers this GCC warning: drivers/infiniband/hw/mlx4/qp.c: In function ‘mlx4_ib_post_send’: drivers/infiniband/hw/mlx4/qp.c:1828:30: warning: ‘vlan’ may be used uninitialized in this function [-Wmaybe-uninitialized]

[PATCH] IB/lmx4: silence GCC warning

2012-09-28 Thread Paul Bolle
Building qp.o (part of the Mellanox ConnectX HCA support driver) triggers this GCC warning: drivers/infiniband/hw/mlx4/qp.c: In function ‘mlx4_ib_post_send’: drivers/infiniband/hw/mlx4/qp.c:1828:30: warning: ‘vlan’ may be used uninitialized in this function [-Wmaybe-uninitialized]