Re: [PATCH] IIO ADC support for AD7923

2013-01-19 Thread Lars-Peter Clausen
Hi, On 01/19/2013 04:05 PM, christophe leroy wrote: > Hi Lars, > > Sorry to respond so late, I've been very busy lately. > Please see answers/questions below > > Main point is that our driver is mainly copied and adapted from AD7298 > driver, and your comments are on things that we have not modi

Re: [PATCH] IIO ADC support for AD7923

2013-01-19 Thread christophe leroy
Hi Lars, Sorry to respond so late, I've been very busy lately. Please see answers/questions below Main point is that our driver is mainly copied and adapted from AD7298 driver, and your comments are on things that we have not modified from AD7298, so what should we do really ? We are a bit n

Re: [PATCH] IIO ADC support for AD7923

2013-01-19 Thread Jonathan Cameron
On 01/18/2013 11:02 PM, Getz, Robin wrote: > On Thu 17 Jan 2013 12:36, Lars-Peter Clausen pondered: >> On 01/17/2013 06:11 PM, Alessandro Rubini wrote: >>> [...] >>> >>> But yes, you are right. I'm working on another I/O subsystem. We are >>> gong to release zio-1.0 in a few days, because the thing

Re: [PATCH] IIO ADC support for AD7923

2013-01-18 Thread Getz, Robin
On Thu 17 Jan 2013 12:36, Lars-Peter Clausen pondered: > On 01/17/2013 06:11 PM, Alessandro Rubini wrote: > > [...] > > > > But yes, you are right. I'm working on another I/O subsystem. We are > > gong to release zio-1.0 in a few days, because the thing is mature > > and used in production. Neithe

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Alessandro Rubini
Thank you Lars for you constructive attitude. See you at fosdem /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at h

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Lars-Peter Clausen
On 01/17/2013 06:11 PM, Alessandro Rubini wrote: >>> I wonder if IIO config symbols should have IIO_ in their name, so >>> people looking at config files knows what they actually are. >>> Actually, all USB drivers have USB in their config name, which is >>> useful even if e.g. "PL2303" cannot be bu

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Alessandro Rubini
>> I wonder if IIO config symbols should have IIO_ in their name, so >> people looking at config files knows what they actually are. >> Actually, all USB drivers have USB in their config name, which is >> useful even if e.g. "PL2303" cannot be but USB. >> >> On the other hand, AD7923 and all the o

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Alessandro Rubini
Thank you Jonathan for replying, I apologize for the delay. >> I wonder if IIO config symbols should have IIO_ in their name, [...] > I have no particular problem with this for new drivers, but > obviously it is an interface change for older ones that may > cause some issues. Yes, that's right.

Re: [PATCH] IIO ADC support for AD7923

2013-01-12 Thread Lars-Peter Clausen
On 01/08/2013 10:14 AM, Alessandro Rubini wrote: >> +config AD7923 > > I wonder if IIO config symbols should have IIO_ in their name, so > people looking at config files knows what they actually are. > Actually, all USB drivers have USB in their config name, which is > useful even if e.g. "PL2303"

Re: [PATCH] IIO ADC support for AD7923

2013-01-12 Thread Jonathan Cameron
On 01/08/2013 09:14 AM, Alessandro Rubini wrote: >> +config AD7923 > > I wonder if IIO config symbols should have IIO_ in their name, so > people looking at config files knows what they actually are. > Actually, all USB drivers have USB in their config name, which is > useful even if e.g. "PL2303"

Re: [PATCH] IIO ADC support for AD7923

2013-01-08 Thread Lars-Peter Clausen
On 01/08/2013 09:42 AM, Christophe Leroy wrote: > This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. > > Signed-off-by: Patrick Vasseur > Signed-off-by: Christophe Leroy Hi, Thanks for the driver, looks pretty good. Some comments inline. - Lars > > diff -uN linux-3.

Re: [PATCH] IIO ADC support for AD7923

2013-01-08 Thread Alessandro Rubini
> +config AD7923 I wonder if IIO config symbols should have IIO_ in their name, so people looking at config files knows what they actually are. Actually, all USB drivers have USB in their config name, which is useful even if e.g. "PL2303" cannot be but USB. On the other hand, AD7923 and all the o

[PATCH] IIO ADC support for AD7923

2013-01-08 Thread Christophe Leroy
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. Signed-off-by: Patrick Vasseur Signed-off-by: Christophe Leroy diff -uN linux-3.7.1/drivers/staging/iio/adc/Kconfig linux/drivers/staging/iio/adc/Kconfig --- linux-3.7.1/drivers/staging/iio/adc/Kconfig 2012-12-17 20:14