Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Jaroslav Kysela
On Mon, 9 Oct 2000, Keith Owens wrote: > On Mon, 9 Oct 2000 12:55:28 +0200 (MEST), > Jaroslav Kysela <[EMAIL PROTECTED]> wrote: > >I fully understand your point, but I don't want to have a special > >case for ISA PnP. What about this change: > > > >#define MODULE_GENERIC_TABLE(gtype,name)

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Keith Owens
On Mon, 9 Oct 2000 12:55:28 +0200 (MEST), Jaroslav Kysela <[EMAIL PROTECTED]> wrote: >I fully understand your point, but I don't want to have a special >case for ISA PnP. What about this change: > >#define MODULE_GENERIC_TABLE(gtype,name)\ >const struct gtype##_id *

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Jaroslav Kysela
On Mon, 9 Oct 2000, Keith Owens wrote: > On Mon, 9 Oct 2000 12:29:19 +0200 (MEST), > Jaroslav Kysela <[EMAIL PROTECTED]> wrote: > >On Mon, 9 Oct 2000, Keith Owens wrote: > >> Modutils and the kernel are compiled from different headers, none of > >> this #include business in modutils. So you

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Keith Owens
On Mon, 9 Oct 2000 12:29:19 +0200 (MEST), Jaroslav Kysela <[EMAIL PROTECTED]> wrote: >On Mon, 9 Oct 2000, Keith Owens wrote: >> Modutils and the kernel are compiled from different headers, none of >> this #include business in modutils. So you must never >> assume that the structures in

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Jaroslav Kysela
On Mon, 9 Oct 2000, Keith Owens wrote: > On Sun, 8 Oct 2000 23:50:43 +0200 (MEST), > Jaroslav Kysela <[EMAIL PROTECTED]> wrote: > > this patch contains following fixes and enhancements to export ISA > >PnP IDs outside the kernel module: > > > >* module.h - added MODULE_GENERIC_TABLE > >*

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Jaroslav Kysela
On Mon, 9 Oct 2000, Keith Owens wrote: On Sun, 8 Oct 2000 23:50:43 +0200 (MEST), Jaroslav Kysela [EMAIL PROTECTED] wrote: this patch contains following fixes and enhancements to export ISA PnP IDs outside the kernel module: * module.h - added MODULE_GENERIC_TABLE * isapnp.h - added

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Keith Owens
On Mon, 9 Oct 2000 12:29:19 +0200 (MEST), Jaroslav Kysela [EMAIL PROTECTED] wrote: On Mon, 9 Oct 2000, Keith Owens wrote: Modutils and the kernel are compiled from different headers, none of this #include linux/xxx.h business in modutils. So you must never assume that the structures in

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Jaroslav Kysela
On Mon, 9 Oct 2000, Keith Owens wrote: On Mon, 9 Oct 2000 12:29:19 +0200 (MEST), Jaroslav Kysela [EMAIL PROTECTED] wrote: On Mon, 9 Oct 2000, Keith Owens wrote: Modutils and the kernel are compiled from different headers, none of this #include linux/xxx.h business in modutils. So you

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-09 Thread Keith Owens
On Mon, 9 Oct 2000 12:55:28 +0200 (MEST), Jaroslav Kysela [EMAIL PROTECTED] wrote: I fully understand your point, but I don't want to have a special case for ISA PnP. What about this change: #define MODULE_GENERIC_TABLE(gtype,name)\ const struct gtype##_id * __module_##gtype##_table =

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Keith Owens
On Mon, 09 Oct 2000 14:35:45 +1100, Keith Owens <[EMAIL PROTECTED]> wrote: >Solution 2: > >struct isapnp_card_id { > unsigned short card_vendor, card_device; > unsigned long driver_data; /* data private to the driver */ > struct { > unsigned short vendor,

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Keith Owens
On Sun, 8 Oct 2000 23:50:43 +0200 (MEST), Jaroslav Kysela <[EMAIL PROTECTED]> wrote: > this patch contains following fixes and enhancements to export ISA >PnP IDs outside the kernel module: > >* module.h - added MODULE_GENERIC_TABLE >* isapnp.h - added 'struct isapnp_device_id' for single

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Jeff Garzik
> +#define MODULE_DEVICE_TABLE(type,name) \ > + MODULE_GENERIC_TABLE(type##_device,name) It looks like that should be "type##_device_id"... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read

[PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Jaroslav Kysela
Hello, this patch contains following fixes and enhancements to export ISA PnP IDs outside the kernel module: * module.h - added MODULE_GENERIC_TABLE * isapnp.h - added 'struct isapnp_device_id' for single devices - added ISAPNP_CARD_TABLE for complex devices * isapnp.c -

[PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Jaroslav Kysela
Hello, this patch contains following fixes and enhancements to export ISA PnP IDs outside the kernel module: * module.h - added MODULE_GENERIC_TABLE * isapnp.h - added 'struct isapnp_device_id' for single devices - added ISAPNP_CARD_TABLE for complex devices * isapnp.c -

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Jeff Garzik
+#define MODULE_DEVICE_TABLE(type,name) \ + MODULE_GENERIC_TABLE(type##_device,name) It looks like that should be "type##_device_id"... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Keith Owens
On Sun, 8 Oct 2000 23:50:43 +0200 (MEST), Jaroslav Kysela [EMAIL PROTECTED] wrote: this patch contains following fixes and enhancements to export ISA PnP IDs outside the kernel module: * module.h - added MODULE_GENERIC_TABLE * isapnp.h - added 'struct isapnp_device_id' for single devices

Re: [PATCH] ISA PnP (2.4.0-test9)

2000-10-08 Thread Keith Owens
On Mon, 09 Oct 2000 14:35:45 +1100, Keith Owens [EMAIL PROTECTED] wrote: Solution 2: struct isapnp_card_id { unsigned short card_vendor, card_device; unsigned long driver_data; /* data private to the driver */ struct { unsigned short vendor, function;