Re: [PATCH] Info dump on Oops or panic()

2007-06-28 Thread Andrew Morton
On Fri, 29 Jun 2007 02:39:33 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Thu, 28 Jun 2007, Joshua Wise wrote: > > > This patch adds a call chain to be invoked when the system oopses or > > panics. > > That seems really fragile, processing a callchain when the system goes to > pa

Re: [PATCH] Info dump on Oops or panic()

2007-06-28 Thread Jiri Kosina
On Thu, 28 Jun 2007, Joshua Wise wrote: > This patch adds a call chain to be invoked when the system oopses or > panics. That seems really fragile, processing a callchain when the system goes to panic is not guaranteed to work. Wouldn't simple function call have higher chances of survival?

Re: [PATCH] Info dump on Oops or panic()

2007-06-28 Thread Andi Kleen
Joshua Wise <[EMAIL PROTECTED]> writes: You are aware that oops screen estate is very precious on standard systems without serial console? > +/* > + * Dump out UTS info on oops / panic. > + */ > + +static int dump_utsname(struct notifier_block *self, unsigned long > v, void *p) > +{ > + print

Re: [PATCH] Info dump on Oops or panic()

2007-06-28 Thread Mike Frysinger
On 6/28/07, Kyle McMartin <[EMAIL PROTECTED]> wrote: On Thu, Jun 28, 2007 at 03:05:56PM -0700, Joshua Wise wrote: > --- a/arch/x86_64/kernel/process.c > +++ b/arch/x86_64/kernel/process.c > @@ -356,6 +356,7 @@ void show_regs(struct pt_regs *regs) > printk("CPU %d:", smp_processor_id()); >

Re: [PATCH] Info dump on Oops or panic()

2007-06-28 Thread Kyle McMartin
On Thu, Jun 28, 2007 at 03:05:56PM -0700, Joshua Wise wrote: > --- a/arch/x86_64/kernel/process.c > +++ b/arch/x86_64/kernel/process.c > @@ -356,6 +356,7 @@ void show_regs(struct pt_regs *regs) > printk("CPU %d:", smp_processor_id()); > __show_regs(regs); > show_trace(NULL, regs,

[PATCH] Info dump on Oops or panic()

2007-06-28 Thread Joshua Wise
From: Joshua Wise <[EMAIL PROTECTED]> Background: When managing a large number of servers, as Google does, it's sometimes useful to get an "at-a-glance" view of a machine when it crashes. When no other post-mortem is possible, it's often useful to know how long the machine has been powered on