Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-13 Thread Dmitry Torokhov
On Tue, Aug 12, 2014 at 10:08:48PM +0100, Nick Dyer wrote: > On 12/08/14 17:41, Stephen Warren wrote: > >> I've reviewed these changes and they look correct to me. Apologies that > >> they slipped through, most of it is bad merging on my part I think. > >> > >> Signed-off-by: Nick Dyer > > > > Do

Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-12 Thread Nick Dyer
On 12/08/14 17:41, Stephen Warren wrote: >> I've reviewed these changes and they look correct to me. Apologies that >> they slipped through, most of it is bad merging on my part I think. >> >> Signed-off-by: Nick Dyer > > Don't you mean Acked-by or Reviewed-by? You are right, Acked-by is probabl

Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-12 Thread Stephen Warren
On 08/12/2014 10:38 AM, Nick Dyer wrote: On 11/08/14 19:03, Dmitry Torokhov wrote: This should fix the following issues reported by Coverity: *** CID 1230625: Logically dead code (DEADCODE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() *** CID 1230627: Missing break in

Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-12 Thread Nick Dyer
On 11/08/14 19:03, Dmitry Torokhov wrote: > This should fix the following issues reported by Coverity: > > *** CID 1230625: Logically dead code (DEADCODE) > /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() > > *** CID 1230627: Missing break in switch (MISSING_BREAK) > /driv

[PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity

2014-08-11 Thread Dmitry Torokhov
This should fix the following issues reported by Coverity: *** CID 1230625: Logically dead code (DEADCODE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() *** CID 1230627: Missing break in switch (MISSING_BREAK) /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_ob