Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-10 Thread Marek Szyprowski
Hi Ravi, Just to let you know - I hope I've finally bisected all the issues related to suspend/resume on Samsung Chromebooks with mainline kernel. I did my tests on Linux next-20180809. The mentioned commit 38ba34a43dbc ("Input: cros_ec_keyb - mark cros_ec_keyb driver as wake enabled device.")

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-10 Thread Marek Szyprowski
Hi Ravi, Just to let you know - I hope I've finally bisected all the issues related to suspend/resume on Samsung Chromebooks with mainline kernel. I did my tests on Linux next-20180809. The mentioned commit 38ba34a43dbc ("Input: cros_ec_keyb - mark cros_ec_keyb driver as wake enabled device.")

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-07 Thread Marek Szyprowski
Hi Ravi, On 2018-08-07 23:59, Ravi Chandra Sadineni wrote: > hi Merek, > > I tried booting a snow device and could not get it to boot it to the > console. I assume i don't have right kernel config. Can you share your > config if possible. I use standard exynos_defconfig bundled with Linux

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-07 Thread Marek Szyprowski
Hi Ravi, On 2018-08-07 23:59, Ravi Chandra Sadineni wrote: > hi Merek, > > I tried booting a snow device and could not get it to boot it to the > console. I assume i don't have right kernel config. Can you share your > config if possible. I use standard exynos_defconfig bundled with Linux

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-07 Thread Ravi Chandra Sadineni
hi Merek, I tried booting a snow device and could not get it to boot it to the console. I assume i don't have right kernel config. Can you share your config if possible. Thanks, RaviOn Mon, Aug 6, 2018 at 4:05 PM Ravi Chandra Sadineni wrote: > > Hi Merek, > > Thanks for the info. Lemme

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-07 Thread Ravi Chandra Sadineni
hi Merek, I tried booting a snow device and could not get it to boot it to the console. I assume i don't have right kernel config. Can you share your config if possible. Thanks, RaviOn Mon, Aug 6, 2018 at 4:05 PM Ravi Chandra Sadineni wrote: > > Hi Merek, > > Thanks for the info. Lemme

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-06 Thread Ravi Chandra Sadineni
Hi Merek, Thanks for the info. Lemme understand what's going on. Will update the thread once I have more info. Thanks, Ravi On Mon, Aug 6, 2018 at 12:15 AM Marek Szyprowski wrote: > > Hi Dmitry > > On 2018-08-06 08:16, Dmitry Torokhov wrote: > > On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-06 Thread Ravi Chandra Sadineni
Hi Merek, Thanks for the info. Lemme understand what's going on. Will update the thread once I have more info. Thanks, Ravi On Mon, Aug 6, 2018 at 12:15 AM Marek Szyprowski wrote: > > Hi Dmitry > > On 2018-08-06 08:16, Dmitry Torokhov wrote: > > On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-06 Thread Marek Szyprowski
Hi Dmitry On 2018-08-06 08:16, Dmitry Torokhov wrote: > On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski > wrote: >> Hi Ravi, >> >> On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: >>> Understood. I am trying to reproduce this issue locally. Wanted to >>> know the version of the kernel so I can

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-06 Thread Marek Szyprowski
Hi Dmitry On 2018-08-06 08:16, Dmitry Torokhov wrote: > On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski > wrote: >> Hi Ravi, >> >> On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: >>> Understood. I am trying to reproduce this issue locally. Wanted to >>> know the version of the kernel so I can

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-06 Thread Dmitry Torokhov
On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski wrote: > > Hi Ravi, > > On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: > > Understood. I am trying to reproduce this issue locally. Wanted to > > know the version of the kernel so I can give a try. Marek, can you > > please confirm the kernel

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-06 Thread Dmitry Torokhov
On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski wrote: > > Hi Ravi, > > On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: > > Understood. I am trying to reproduce this issue locally. Wanted to > > know the version of the kernel so I can give a try. Marek, can you > > please confirm the kernel

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-05 Thread Marek Szyprowski
Hi Ravi, On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: > Understood. I am trying to reproduce this issue locally. Wanted to > know the version of the kernel so I can give a try. Marek, can you > please confirm the kernel version. > Yes, sorry for the missing context, I was in hurry writing

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-05 Thread Marek Szyprowski
Hi Ravi, On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: > Understood. I am trying to reproduce this issue locally. Wanted to > know the version of the kernel so I can give a try. Marek, can you > please confirm the kernel version. > Yes, sorry for the missing context, I was in hurry writing

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Ravi Chandra Sadineni
Understood. I am trying to reproduce this issue locally. Wanted to know the version of the kernel so I can give a try. Marek, can you please confirm the kernel version. Thanks, On Fri, Aug 3, 2018 at 9:08 AM Dmitry Torokhov wrote: > On Fri, Aug 3, 2018 at 8:51 AM Ravi Chandra Sadineni >

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Ravi Chandra Sadineni
Understood. I am trying to reproduce this issue locally. Wanted to know the version of the kernel so I can give a try. Marek, can you please confirm the kernel version. Thanks, On Fri, Aug 3, 2018 at 9:08 AM Dmitry Torokhov wrote: > On Fri, Aug 3, 2018 at 8:51 AM Ravi Chandra Sadineni >

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Dmitry Torokhov
On Fri, Aug 3, 2018 at 8:51 AM Ravi Chandra Sadineni wrote: > > Hi Marek, > > Can you please give me little more context ? Snow is still on 3.8.11. This > patch is not backported to 3.8.11. Are you trying to flash a different kernel > on snow? > Ravi, from upstream perspective what kernel

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Dmitry Torokhov
On Fri, Aug 3, 2018 at 8:51 AM Ravi Chandra Sadineni wrote: > > Hi Marek, > > Can you please give me little more context ? Snow is still on 3.8.11. This > patch is not backported to 3.8.11. Are you trying to flash a different kernel > on snow? > Ravi, from upstream perspective what kernel

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Ravi Chandra Sadineni
Hi Marek, Can you please give me little more context ? Snow is still on 3.8.11. This patch is not backported to 3.8.11. Are you trying to flash a different kernel on snow? Thanks, Ravi On Fri, Aug 3, 2018 at 12:26 AM Marek Szyprowski wrote: > Hi All, > > On 2018-06-06 00:44, Ravi Chandra

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Ravi Chandra Sadineni
Hi Marek, Can you please give me little more context ? Snow is still on 3.8.11. This patch is not backported to 3.8.11. Are you trying to flash a different kernel on snow? Thanks, Ravi On Fri, Aug 3, 2018 at 12:26 AM Marek Szyprowski wrote: > Hi All, > > On 2018-06-06 00:44, Ravi Chandra

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Marek Szyprowski
Hi All, On 2018-06-06 00:44, Ravi Chandra Sadineni wrote: > Remove the unnecessary check before calling pm_wakeup_event. If the > device is not wake enabled, this call is no-op anyway. > > Signed-off-by: Ravi Chandra Sadineni This patch breaks suspend/resume on Samsung Exynos5250 Snow

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-08-03 Thread Marek Szyprowski
Hi All, On 2018-06-06 00:44, Ravi Chandra Sadineni wrote: > Remove the unnecessary check before calling pm_wakeup_event. If the > device is not wake enabled, this call is no-op anyway. > > Signed-off-by: Ravi Chandra Sadineni This patch breaks suspend/resume on Samsung Exynos5250 Snow

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-06-12 Thread Dmitry Torokhov
On Tue, Jun 05, 2018 at 03:44:57PM -0700, Ravi Chandra Sadineni wrote: > Remove the unnecessary check before calling pm_wakeup_event. If the > device is not wake enabled, this call is no-op anyway. > > Signed-off-by: Ravi Chandra Sadineni Applied, thank you. > --- >

Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-06-12 Thread Dmitry Torokhov
On Tue, Jun 05, 2018 at 03:44:57PM -0700, Ravi Chandra Sadineni wrote: > Remove the unnecessary check before calling pm_wakeup_event. If the > device is not wake enabled, this call is no-op anyway. > > Signed-off-by: Ravi Chandra Sadineni Applied, thank you. > --- >

[PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-06-05 Thread Ravi Chandra Sadineni
Remove the unnecessary check before calling pm_wakeup_event. If the device is not wake enabled, this call is no-op anyway. Signed-off-by: Ravi Chandra Sadineni --- drivers/input/keyboard/cros_ec_keyb.c | 30 ++- 1 file changed, 11 insertions(+), 19 deletions(-) diff

[PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

2018-06-05 Thread Ravi Chandra Sadineni
Remove the unnecessary check before calling pm_wakeup_event. If the device is not wake enabled, this call is no-op anyway. Signed-off-by: Ravi Chandra Sadineni --- drivers/input/keyboard/cros_ec_keyb.c | 30 ++- 1 file changed, 11 insertions(+), 19 deletions(-) diff