Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-09 Thread 'Dmitry Torokhov'
On Tue, Mar 09, 2021 at 10:53:34PM +0800, jingle.wu wrote: > Hi Dmitry: > > Was this the only issue with the updated patch? Did it work for you > otherwise? > -> Yes, the updated patch can work successfully after fix this issue. OK, great, I applied it. Thanks. -- Dmitry

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-09 Thread jingle.wu
:38 AM To: jingle Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'dave.wang'; 'josh.chen' Subject: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Hi Jingle, On Mon, Mar 08, 2021 at 04:56:14PM +0800, jingle wrote: > Hi Dmitry: > > 1. missing "i<"

Re: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-08 Thread Dan Carpenter
Hi 'Dmitry, url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/Re-PATCH-Input-elan_i2c-Reduce-the-resume-time-for-new-dev-ices/20210308-111956 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: x86_64-randconfig-m001-20210308 (attached as .config

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-08 Thread 'Dmitry Torokhov'
Hi Jingle, On Mon, Mar 08, 2021 at 04:56:14PM +0800, jingle wrote: > Hi Dmitry: > > 1. missing "i<" > + u32 quirks = 0; > + int i; > + > + for (i = 0; ARRAY_SIZE(elan_i2c_quirks); i++) { > > -> for (i = 0; i > 2. elan_resume () funtion are different with at Chromeos driver. > @@

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-08 Thread jingle
m linux kernel to chromeos? THANKS JINGLE -Original Message- From: 'Dmitry Torokhov' [mailto:dmitry.torok...@gmail.com] Sent: Monday, March 08, 2021 11:18 AM To: jingle Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'dave.wang'; 'josh.chen' Subject: Re: [PATCH] Input: elan_i2c - Reduce t

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-07 Thread 'Dmitry Torokhov'
Hi Jingle, On Fri, Mar 05, 2021 at 09:50:35AM +0800, jingle wrote: > HI Dmitry: > > 1. You mean to let all devices ignore skipping reset/sleep part of device > initialization? > 2. The test team found that some old firmware will have errors (invalid > report etc...), so ELAN can only ensure that

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread jingle
- From: 'Dmitry Torokhov' [mailto:dmitry.torok...@gmail.com] Sent: Friday, March 05, 2021 9:31 AM To: jingle Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'dave.wang'; 'josh.chen' Subject: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Hi Jingle, On Fri, Mar 05, 2021

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread 'Dmitry Torokhov'
Hi Jingle, On Fri, Mar 05, 2021 at 09:24:05AM +0800, jingle wrote: > HI Dmitry: > > In this case (in the newer parts behavior regarding need to reset after > powering them on), it is consistent with the original driver behavior with > any new or old device > (be called

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread jingle
ks" is equal 0 at probe state.) THANKS JINGLE -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, March 05, 2021 8:55 AM To: jingle.wu Cc: linux-kernel; linux-input; phoenix; dave.wang; josh.chen Subject: Re: [PATCH] Input: elan_i2c - Reduce the resu

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread Dmitry Torokhov
Hi Jingle, On Tue, Mar 02, 2021 at 09:04:57AM +0800, jingle.wu wrote: > HI Dmitry: > > So data->ops->initialize(client) essentially performs reset of the > controller (we may want to rename it even) and as far as I understand > you would want to avoid resetting the controller on newer devices, >

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-01 Thread jingle.wu
HI Dmitry: So data->ops->initialize(client) essentially performs reset of the controller (we may want to rename it even) and as far as I understand you would want to avoid resetting the controller on newer devices, right? -> YES My question is how behavior of older devices differ from the new