Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-08 Thread Gonzalez, Alex
> >My concern with trying to do the address selection without RST line is >that it is quite unreliable, as it really depends on timings between the >chip reset, INT line being driven by the host and then being switched to >input. I think you are right. thinking twice I should be able to fake the r

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Dmitry Torokhov
On Mon, Jan 07, 2019 at 04:42:26PM +, Gonzalez, Alex wrote: > Hi Bastien, > > >Given that we do have access to the datasheet, it would also be useful > >for the patch to mention where in the datasheet it says that the reset > >line can be left pulled-up, > > The pin description table on secti

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Gonzalez, Alex
> >If it doesn't work with the vendor code, then we might not want to make >it work with our driver either. > Thanks Bastien. The vendor code does seem to require both INT and RESET gpios.

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Gonzalez, Alex
Hi Bastien, >Given that we do have access to the datasheet, it would also be useful >for the patch to mention where in the datasheet it says that the reset >line can be left pulled-up, The pin description table on section 4, on the "Reset pin" row, contains a remark as follows: External 10K pul

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Bastien Nocera
On Mon, 2019-01-07 at 16:56 +0100, Bastien Nocera wrote: > Given that we do have access to the datasheet, it would also be > useful > for the patch to mention where in the datasheet it says that the > reset > line can be left pulled-up, or mention on which shipping device this > setup is already us

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Bastien Nocera
On Sat, 2019-01-05 at 22:51 +, Dmitry Torokhov wrote: > Hi Alex, > > On Fri, Jan 04, 2019 at 05:00:48PM +0100, Alex Gonzalez wrote: > > The Goodix touch controller allows the use of two optional GPIOs > > (RESET > > and INT) to reset the touch controller, select the I2C address of > > the > >

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Gonzalez, Alex
Hi Dmitry, Thanks for your quick reply. > >I do not have a datasheet for the device, so I am not sure if reset line >is actually needed to put the device into sleep mode. As far as I can >see from the code we suspend it by pulsing INT line and then sending a >command to the controller, and resumi

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-05 Thread Dmitry Torokhov
Hi Alex, On Fri, Jan 04, 2019 at 05:00:48PM +0100, Alex Gonzalez wrote: > The Goodix touch controller allows the use of two optional GPIOs (RESET > and INT) to reset the touch controller, select the I2C address of the > device and exit the device from sleep mode. > > The current implementation re

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-04 Thread Andreas Gohr
> Designs that only provide the INT line are able to operate the touch on > the default I2C address but will not be able to reset the touch via > software or place the device in sleep mode. This sounds exactly like the problem I'm having with the One-Mix Yoga 2 I described a few days ago. I appli

[PATCH] Input: goodix - decouple irq and reset lines

2019-01-04 Thread Alex Gonzalez
The Goodix touch controller allows the use of two optional GPIOs (RESET and INT) to reset the touch controller, select the I2C address of the device and exit the device from sleep mode. The current implementation requires both GPIOs to be provided, however, it is possible to provide only the INT l

[PATCH] Input: goodix - decouple irq and reset lines

2019-01-04 Thread Alex Gonzalez
The current implementation on the Goodix driver requires the two optional GPIOs (RESET and INT) to be provided. However, it is possible to designs the RESET line pulled-up and only provide the INT line. Such designs do not work with the current implementation. The patch attached allows for design