Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-30 Thread Benson Leung
Actually, I take it back. It doesn't look like it's necessary. Benson On Mon, Jul 30, 2012 at 12:28 PM, Benson Leung wrote: > Hi Dmitry, > > Yes I see Neil's changes. Thank you for letting me know. > > By the way, looking at Neil's changes, would it make sense to check > for device_may_wakeup(de

Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-30 Thread Benson Leung
Hi Dmitry, Yes I see Neil's changes. Thank you for letting me know. By the way, looking at Neil's changes, would it make sense to check for device_may_wakeup(dev) like in my patch so that the wakeup behavior can be turned off by setting power/wakeup to disabled? Benson On Sun, Jul 29, 2012 at 1

Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-29 Thread Dmitry Torokhov
Hi Benson, On Wed, Jul 25, 2012 at 11:11:53PM -0700, Benson Leung wrote: > If a button is configured to wake the system, report a pm wakeup event. > Thank you for your patch, however I applied more complete patch sent by NeilBrown. > Signed-off-by: Benson Leung > --- > drivers/input/keyboard/

[PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-25 Thread Benson Leung
If a button is configured to wake the system, report a pm wakeup event. Signed-off-by: Benson Leung --- drivers/input/keyboard/gpio_keys.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index cb