Re: [PATCH] Input: gpio_keys - wakeup_trigger

2013-09-19 Thread Benson Leung
Hi Tomasz, On Sat, Sep 14, 2013 at 5:16 AM, Tomasz Figa wrote: > I don't like two things in this patch. > > First is that this looks completely like a configuration option, not > hardware description, so it's not something that should be put into DT. > Especially that users might want to use anot

Re: [PATCH] Input: gpio_keys - wakeup_trigger

2013-09-14 Thread Tomasz Figa
Hi Benson, On Friday 13 of September 2013 14:52:40 Benson Leung wrote: > Allow wakeup_trigger to be defined per gpio button. Currently, all > gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING. > It may be more appropriate to only wake the system on one edge, for > example if th

Re: [PATCH] Input: gpio_keys - wakeup_trigger

2013-09-13 Thread Doug Anderson
Benson, On Fri, Sep 13, 2013 at 2:52 PM, Benson Leung wrote: > Allow wakeup_trigger to be defined per gpio button. Currently, all > gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING. > It may be more appropriate to only wake the system on one edge, for example > if the gpio is

[PATCH] Input: gpio_keys - wakeup_trigger

2013-09-13 Thread Benson Leung
Allow wakeup_trigger to be defined per gpio button. Currently, all gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING. It may be more appropriate to only wake the system on one edge, for example if the gpio is for a Lid Switch. Signed-off-by: Benson Leung --- .../devicetree/bi