Re: [PATCH] Input: psmouse - cleanup Focaltech code

2016-10-24 Thread Dmitry Torokhov
On Sat, Oct 08, 2016 at 01:38:56PM +0300, Dmitry Tunin wrote: > psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as > "FocaltechPS/2 Focaltech Focaltech Touchpad" > > In focaltech_report_state() pointer to psmouse->dev is already stored as *dev > > Signed-off-by:

Re: [PATCH] Input: psmouse - cleanup Focaltech code

2016-10-24 Thread Dmitry Torokhov
On Sat, Oct 08, 2016 at 01:38:56PM +0300, Dmitry Tunin wrote: > psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as > "FocaltechPS/2 Focaltech Focaltech Touchpad" > > In focaltech_report_state() pointer to psmouse->dev is already stored as *dev > > Signed-off-by:

Re: [PATCH] Input: psmouse - cleanup Focaltech code

2016-10-17 Thread Dmitry Tunin
Other drivers, like Synaptics use the same as I suggested. They even shorten in psmouse-base.c psmouse_protocol.name to SynPS/2. You used FocaltechPS/2. I think it is OK. I do not think it is a big problem of changing the naming. It happens a lot. I still have the hardware and I am still

Re: [PATCH] Input: psmouse - cleanup Focaltech code

2016-10-17 Thread Dmitry Tunin
Other drivers, like Synaptics use the same as I suggested. They even shorten in psmouse-base.c psmouse_protocol.name to SynPS/2. You used FocaltechPS/2. I think it is OK. I do not think it is a big problem of changing the naming. It happens a lot. I still have the hardware and I am still

Re: [PATCH] Input: psmouse - cleanup Focaltech code

2016-10-17 Thread Mathias Gottschlag
The changes look good to me. However, what wording do other drivers use? I've seen "TouchPad" with a capital P before. If this patch breaks scripts searching for that string anyways, that's an opportunity to unify the capitalization there. It probably doesn't matter, though... I don't see a

Re: [PATCH] Input: psmouse - cleanup Focaltech code

2016-10-17 Thread Mathias Gottschlag
The changes look good to me. However, what wording do other drivers use? I've seen "TouchPad" with a capital P before. If this patch breaks scripts searching for that string anyways, that's an opportunity to unify the capitalization there. It probably doesn't matter, though... I don't see a

[PATCH] Input: psmouse - cleanup Focaltech code

2016-10-08 Thread Dmitry Tunin
psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as "FocaltechPS/2 Focaltech Focaltech Touchpad" In focaltech_report_state() pointer to psmouse->dev is already stored as *dev Signed-off-by: Dmitry Tunin --- drivers/input/mouse/focaltech.c | 6

[PATCH] Input: psmouse - cleanup Focaltech code

2016-10-08 Thread Dmitry Tunin
psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as "FocaltechPS/2 Focaltech Focaltech Touchpad" In focaltech_report_state() pointer to psmouse->dev is already stored as *dev Signed-off-by: Dmitry Tunin --- drivers/input/mouse/focaltech.c | 6 +++--- 1 file changed,